Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor could not be loaded after permissions change #8678

Open
ScharfViktor opened this issue Mar 18, 2024 · 2 comments
Open

Editor could not be loaded after permissions change #8678

ScharfViktor opened this issue Mar 18, 2024 · 2 comments
Labels

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Mar 18, 2024

we fixed case where user cannot change permissions of the locked file
but we didn't fix all the cases
#8273 (comment) this workaround fixes only issue with file
IMHO we cannot disable change member role or change share role of folder if one file in the space or folder is locked

case 1 (project space)
steps:

  • admin adds einstein with the editor permissions to space
  • admin created the file.txt
  • einstein locked the file
curl -XLOCK 'https://localhost:9200/remote.php/dav/spaces/projectSpaceUUID/file.txt' -ueinstein:relativity \
-H "Content-Type: application/xml" -H "timeout: Second-300" -d "<?xml version='1.0' encoding='UTF-8'?><d:lockinfo xmlns:d='DAV:'><d:lockscope><d:shared/></d:lockscope></d:lockinfo>" -vk
  • admin removes/updates einstein space role.
  • admin tries to open file

case 2 (folder with files)

  • admin created the f1/file.txt and shared folderf1 to einstein with the editor permissions.
  • einstein locked the file
curl -XLOCK 'https://localhost:9200/remote.php/dav/spaces/projectSpaceUUID/file.txt' -ueinstein:relativity \
-H "Content-Type: application/xml" -H "timeout: Second-300" -d "<?xml version='1.0' encoding='UTF-8'?><d:lockinfo xmlns:d='DAV:'><d:lockscope><d:shared/></d:lockscope></d:lockinfo>" -vk
  • admin remove/update share permissions of folder f1
  • admin tries to open file inside of the folder

Actual: file is locked. Admin and another users cannot open this file:
image

@tbsbdr
Copy link

tbsbdr commented May 27, 2024

@ScharfViktor whats the expected behaviour?

@tbsbdr tbsbdr added Priority:p3-medium Normal priority and removed Priority:p2-high Escalation, on top of current planning, release blocker labels May 27, 2024
@tbsbdr tbsbdr moved this from Prio 2 to Prio 3 or less in Infinite Scale Team Board May 27, 2024
@ScharfViktor
Copy link
Contributor Author

I'll test it again with new wopi collaboration.

My suggestion of expected behavior (similar to google drive sharing):
sharer can be able change role of the shared locked file / shared folder which contains the locked file/ role of member the space which contains the locked file

recipient see message: Your access has changed. please reload the page. After reloading page -> recipient cannot edit file, file is unlocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Prio 3 or less
Development

No branches or pull requests

2 participants