Handle the remove/update share permissions response.

[2403905]

Describe the bug

Regarding the backend changes https://github.com/owncloud/ocis/issues/8273 we should handle the remove/update share permissions response 423 when the file is locked.

Steps to reproduce

1. admin created the file.txt and shared to einstein with the editor permissions.
2. einstein locked the file

curl -XLOCK 'https://localhost:9200/remote.php/dav/spaces/storage-users-1$some-admin-user-id-0000-000000000000!some-admin-user-id-0000-000000000000/file.txt' -ueinstein:relativity \
-H "Content-Type: application/xml" -H "timeout: Second-300" -d "<?xml version='1.0' encoding='UTF-8'?><d:lockinfo xmlns:d='DAV:'><d:lockscope><d:shared/></d:lockscope></d:lockinfo>" -vk

3. admin tries to remove/update share permissions.

Expected behavior

admin get the message that the file is locked.

Actual behavior

On the delete share action user recursively gets the removing dialog window

Setup

local

OCIS_XXX=somevalue
OCIS_YYY=somevalue
PROXY_XXX=somevalue

Additional context

Add any other context about the problem here.

[ScharfViktor]

we disable on web delete rename or move action if file is locked

If possible, I would prefer that the user not have the ability to change or delete the resource share.

my expected behavior:

[AlexAndBear]

@kulmann do you agree with this behavior ? Or should we make it more clear to the user ?

[kulmann]

@AlexAndBear yes, that would be fine. The file name should have the lock information, both in the file list and in the right sidebar header section. As long as that shows the lock information (i.e. small icon with a lock) I wouldn't clutter the UI with even more lock information. Disabling write actions is sufficient then. 👍

[ScharfViktor]

re-tested. can confirm that case with file is fixed

@kulmann @micbar I'm sorry to say, but we didn't have all the cases covered.
owncloud/ocis#8273 (comment) this workaround fixes only issue with file
IMHO we cannot disable change member role or change share role of folder if one file in the space or folder is locked

case 1 (project space)
steps:

• admin created the file.txt and shared to einstein with the editor permissions.
• einstein locked the file

curl -XLOCK 'https://localhost:9200/remote.php/dav/spaces/projectSpaceUUID/file.txt' -ueinstein:relativity \
-H "Content-Type: application/xml" -H "timeout: Second-300" -d "<?xml version='1.0' encoding='UTF-8'?><d:lockinfo xmlns:d='DAV:'><d:lockscope><d:shared/></d:lockscope></d:lockinfo>" -vk

• admin removes/updates einstein space role.

case 2 (folder with files)

• admin created the f1/file.txt and shared folderf1 to einstein with the editor permissions.
• einstein locked the file

curl -XLOCK 'https://localhost:9200/remote.php/dav/spaces/projectSpaceUUID/file.txt' -ueinstein:relativity \
-H "Content-Type: application/xml" -H "timeout: Second-300" -d "<?xml version='1.0' encoding='UTF-8'?><d:lockinfo xmlns:d='DAV:'><d:lockscope><d:shared/></d:lockscope></d:lockinfo>" -vk

• admin remove/update share permissions of folder f1

Actual: file is locked. Admin and another users cannot open this file:

[ScharfViktor]

close in favor owncloud/ocis#8678