Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable share role and share drop buttons when resource is locked #10514

Merged
merged 9 commits into from
Mar 5, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Feb 26, 2024

Description

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Feb 26, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear force-pushed the issues/10507 branch 2 times, most recently from ab2a7eb to bdc5988 Compare February 26, 2024 12:23
@AlexAndBear AlexAndBear changed the base branch from master to stable-8.0 February 26, 2024 12:31
@AlexAndBear
Copy link
Contributor Author

Note: I won't write a changelog for this, because the lock issue will be solved later in ocis 6 and we can remove this restriction again later

@AlexAndBear AlexAndBear requested a review from kulmann February 26, 2024 12:47
@kulmann
Copy link
Contributor

kulmann commented Feb 26, 2024

Note: I won't write a changelog for this, because the lock issue will be solved later in ocis 6 and we can remove this restriction again later

Please do. Any bugfix on the stable branch needs a changelog item for transparency.

@AlexAndBear AlexAndBear requested a review from dschmidt February 26, 2024 12:47
@AlexAndBear
Copy link
Contributor Author

Note: I won't write a changelog for this, because the lock issue will be solved later in ocis 6 and we can remove this restriction again later

Please do. Any bugfix on the stable branch needs a changelog item for transparency.

done

@AlexAndBear AlexAndBear requested a review from kulmann February 26, 2024 12:57
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@AlexAndBear AlexAndBear requested review from kulmann and removed request for kulmann February 27, 2024 22:41
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
41.18% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@AlexAndBear AlexAndBear requested a review from kulmann March 5, 2024 10:10
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@AlexAndBear AlexAndBear merged commit 3c560ad into stable-8.0 Mar 5, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issues/10507 branch March 5, 2024 12:50
@micbar micbar mentioned this pull request Mar 13, 2024
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants