-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable share role and share drop buttons when resource is locked #10514
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
ab2a7eb
to
bdc5988
Compare
Note: I won't write a changelog for this, because the lock issue will be solved later in ocis 6 and we can remove this restriction again later |
Please do. Any bugfix on the stable branch needs a changelog item for transparency. |
done |
packages/web-app-files/src/components/SideBar/Shares/Collaborators/RoleDropdown.vue
Outdated
Show resolved
Hide resolved
changelog/unreleased/enhancement-indicate-shares-not-managable-due-to-file-locking
Outdated
Show resolved
Hide resolved
changelog/unreleased/enhancement-indicate-shares-not-managable-due-to-file-locking
Outdated
Show resolved
Hide resolved
changelog/unreleased/enhancement-indicate-shares-not-managable-due-to-file-locking
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Collaborators/EditDropdown.vue
Outdated
Show resolved
Hide resolved
d3e0642
to
fa5f5cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
packages/web-app-files/src/components/SideBar/Shares/Collaborators/EditDropdown.vue
Show resolved
Hide resolved
packages/design-system/src/components/OcResourceIcon/OcResourceIcon.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/OcResourceIcon/OcResourceIcon.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/OcResourceIcon/OcResourceIcon.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/OcResourceIcon/OcResourceIcon.vue
Outdated
Show resolved
Hide resolved
37e90c1
to
d58dfad
Compare
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: