Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create a file with Collabora in a Space accessed via an edit public link #8691

Closed
nicholas-wilson-au opened this issue Mar 19, 2024 · 10 comments · Fixed by #8828
Closed

Comments

@nicholas-wilson-au
Copy link

Create an editable public link to a Space.

Access this link and create a new odt file.

It fails with X-Request-Id: 743a0be4-8862-46b8-9a03-baf7f9d7f827

Tested on https://ocis.ocis-wopi.released.owncloud.works/

@2403905 2403905 self-assigned this Mar 21, 2024
@2403905 2403905 moved this from Qualification to Prio 2 in Infinite Scale Team Board Mar 22, 2024
@2403905
Copy link
Contributor

2403905 commented Mar 22, 2024

The user got 401 when trying to create the document and 500 when trying to edit.
@micbar Need to classification

@2403905 2403905 removed their assignment Mar 22, 2024
@dragonchaser dragonchaser self-assigned this Apr 4, 2024
@dragonchaser dragonchaser moved this from Prio 2 to In progress in Infinite Scale Team Board Apr 4, 2024
@dragonchaser
Copy link
Member

Can reproduce

@dragonchaser
Copy link
Member

seems to be an issue with the permissions I see this error:
{"level":"error","service":"frontend","pkg":"rhttp","traceid":"dee4da1ed0bc08585f38f5cd53dca81f","request-id":"d972a73c-526a-4338-8150-95695a460714","error":"rpc error: code = PermissionDenied desc = gateway: error calling OpenInApp: rpc error: code = PermissionDenied desc = auth: core access token is invalid","time":"2024-04-08T07:38:02Z","line":"github.com/cs3org/reva/v2@v2.19.2-0.20240404085416-251ba8d12f6f/internal/http/services/appprovider/errors.go:63","message":"Error contacting the requested application, please use a different one or try again later"}

rhafer added a commit to rhafer/ocis that referenced this issue Apr 10, 2024
… folder

The public share authentication middleware only allowed to open existing documents
the /app/new route was missing.

Fixes owncloud#8691
@individual-it
Copy link
Member

individual-it commented Apr 11, 2024

ToDo QA-team:

@dragonchaser
Copy link
Member

The PR from @rhafer fixes the 401 for spaces as well but there is still the 500 that occurs in both cases, the error is coming from https://github.com/cs3org/reva/blob/767b09035271307bd2b8a01d8fa732e0bcf26ae1/internal/http/services/appprovider/appprovider.go#L446-L457 I assume. I guess the token is not passed properly there. The error is not limited to collabora, happens also with onlyoffice.

@dj4oC
Copy link
Contributor

dj4oC commented Apr 12, 2024

Do we have an ETA for a version including that fix?

@rhafer
Copy link
Contributor

rhafer commented Apr 12, 2024

@dj4oC Given @dragonchaser 's last answer the fix doesn't seem to be complete for now. So unfortunately we can't give any ETA.

@dj4oC
Copy link
Contributor

dj4oC commented Apr 12, 2024

Sure @rhafer it was more asking whether this is going to be next week, the week after or ...
users are chasing us...

rhafer added a commit to rhafer/ocis that referenced this issue Apr 12, 2024
… folder

The public share authentication middleware only allowed to open existing documents
the /app/new route was missing.

Fixes owncloud#8691
@dragonchaser
Copy link
Member

@dj4oC We are working on it as fast as possible, unfortunately wopi issues are not that easy to track down, we hope for this week.

rhafer added a commit that referenced this issue Apr 15, 2024
… folder

The public share authentication middleware only allowed to open existing documents
the /app/new route was missing.

Fixes #8691
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Apr 15, 2024
ownclouders pushed a commit that referenced this issue Apr 15, 2024
… folder

The public share authentication middleware only allowed to open existing documents
the /app/new route was missing.

Fixes #8691
@rhafer rhafer moved this from Done to Needs Tests in Infinite Scale Team Board Apr 16, 2024
rhafer added a commit to rhafer/ocis that referenced this issue Apr 16, 2024
… folder

The public share authentication middleware only allowed to open existing documents
the /app/new route was missing.

Fixes owncloud#8691

(cherry picked from commit 8d5a0c6)
@dragonchaser dragonchaser removed their assignment Apr 17, 2024
rhafer added a commit to rhafer/ocis that referenced this issue Apr 17, 2024
… folder

The public share authentication middleware only allowed to open existing documents
the /app/new route was missing.

Fixes owncloud#8691

(cherry picked from commit 8d5a0c6)
@amrita-shrestha
Copy link
Contributor

ToDo QA-team:

  • add API tests for /app/open and /app/new endpoints on normal files, shares, public links of files, public links of folders

will be covered in this issue #8712 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants