[QA] Re-Sharer can increase permissions

[jnweiger]

Setup via docker-compose-eos-test.yml from branch fix-yml-for-rc5 on localhost

Via WEB UI:

• login as einstein, share a folder with richard as viewer only
• log in as richard, accept the folder, re-share to moss as editor
• login as moss, accept the folder, enter the folder, upload a file into it. Works. BAD.
• check the situation as einstein:
  

Although richard is clearly only Viewer, and moss received the share through richard, moss is Editor.
(At least einstein can clearly see what happend). Okayish.

Expected behaviour: share receiver can only reshare with same or subset of his own permissions.

[jnweiger]

A public link created by richard with Editor role behaves differently:
Richard sees, that the link has Editor permissions, but
users of the link cannot upload until einstein gives richard editor permissons.

While this behaviour is technically cool, it is absolutely not transparent for the participants.
My expected behaviour for the public link would be the same: richard should only be able to set the same permissions that he has.

Editor and other choices should be grayed out, and have a tooltip explaining that the own permissions are currently insufficient.

[jnweiger]

According to @pmaier1 re-sharing should not be possible at all.

[micbar]

@butonic Can you please confirm, that this was expected?

[davitol]

Kind of dupe of #552 ?

[dpakach]

Also similar issue owncloud/product#270

[exalate-issue-sync]

Jörn Friedrich Dreyer commented: another dupe: #893

inital PR to fix it: cs3org/reva#1368

[jnweiger]

Retested with ocis-1.0.0-rc8 via ocis/deployments/examples/ocis_traefik/

No more resharing conspiracy possible:
share receiver gets an GRPC error when trying to re-share a readonly share.

That is an acceptable workaround, but not nice.

[pmaier1]

Retested with ocis-1.0.0-rc8 via ocis/deployments/examples/ocis_traefik/

Try a reload after encountering the error. Unfortunately the share is created nevertheless. But luckily the 3rd user does not get the share.

[refs]

@pmaier1 @micbar just want to bring this to the picture again. As it has p2-high is this something we should re-test and come to a conclusion?

[micbar]

We should fix it during our hardening of the share features.

[ScharfViktor]

re-sharing is off. Need a re-test when we turn it on

[micbar]

Resharing is disabled.