COPY file/folder to share mountpoint: inconsistent behavior between dav paths

[saw-jan]

1. File to shared File

old/new/spaces dav path:

curl -XCOPY "https://localhost:9200/remote.php/webdav/demo-lorem.txt" \       
-H"Destination: https://localhost:9200/remote.php/webdav/Shares/admin-lorem.txt" \
-udemo:demo -vk

curl -XCOPY "https://localhost:9200/remote.php/dav/files/demo/demo-lorem.txt" \       
-H"Destination: https://localhost:9200/remote.php/dav/files/demo/Shares/admin-lorem.txt" \
-udemo:demo -vk

curl -XCOPY "https://localhost:9200/remote.php/dav/spaces/{demo-space-id}/demo-lorem.txt" \       
-H"Destination: https://localhost:9200/remote.php/dav/spaces/{shares-space-id}/admin-lorem.txt" \
-udemo:demo -vk

• < HTTP/1.1 204 No Content ❗
• share is not deleted ✔️
• share mountpoint is not lost ✔️

2. File to shared Folder

old/new dav path:

curl -XCOPY "https://localhost:9200/remote.php/webdav/demo-lorem.txt" \       
-H"Destination: https://localhost:9200/remote.php/webdav/Shares/admin-folder" \
-udemo:demo -vk

curl -XCOPY "https://localhost:9200/remote.php/dav/files/demo/demo-lorem.txt" \       
-H"Destination: https://localhost:9200/remote.php/dav/files/demo/Shares/admin-folder" \
-udemo:demo -vk

• < HTTP/1.1 400 Bad Request ✔️
• share is not deleted ✔️
• share mountpoint is not lost ✔️

spaces dav path:

curl -XCOPY "https://localhost:9200/remote.php/dav/spaces/{demo-space-id}/demo-lorem.txt" \       
-H"Destination: https://localhost:9200/remote.php/dav/spaces/{shares-space-id}/admin-folder" \
-udemo:demo -vk

• < HTTP/1.1 412 Precondition Failed ❓
• share is deleted ❗
• share mountpoint is lost ❗

3. Folder to shared File

old/new dav path:

curl -XCOPY "https://localhost:9200/remote.php/webdav/demo-folder" \       
-H"Destination: https://localhost:9200/remote.php/webdav/Shares/admin-lorem.txt" \
-udemo:demo -vk

curl -XCOPY "https://localhost:9200/remote.php/dav/files/demo/demo-folder" \       
-H"Destination: https://localhost:9200/remote.php/dav/files/demo/Shares/admin-lorem.txt" \
-udemo:demo -vk

• < HTTP/1.1 400 Bad Request ✔️
• share is not deleted ✔️
• share mountpoint is not lost ✔️

spaces dav path:

curl -XCOPY "https://localhost:9200/remote.php/dav/spaces/{demo-space-id}/demo-folder" \       
-H"Destination: https://localhost:9200/remote.php/dav/spaces/{shares-space-id}/admin-lorem.txt" \
-udemo:demo -vk

• < HTTP/1.1 403 Forbidden ❓
• share is not deleted ✔️
• share mountpoint is not lost ✔️

4. Folder to shared Folder

old/new dav path:

curl -XCOPY "https://localhost:9200/remote.php/webdav/demo-lorem.txt" \       
-H"Destination: https://localhost:9200/remote.php/webdav/Shares/admin-folder" \
-udemo:demo -vk

curl -XCOPY "https://localhost:9200/remote.php/dav/files/demo/demo-lorem.txt" \       
-H"Destination: https://localhost:9200/remote.php/dav/files/demo/Shares/admin-folder" \
-udemo:demo -vk

• < HTTP/1.1 400 Bad Request ✔️
• share is not deleted ✔️
• share mountpoint is not lost ✔️

spaces dav path:

curl -XCOPY "https://localhost:9200/remote.php/dav/spaces/{demo-space-id}/demo-lorem.txt" \       
-H"Destination: https://localhost:9200/remote.php/dav/spaces/{shares-space-id}/admin-folder" \
-udemo:demo -vk

• < HTTP/1.1 204 No Content ❓
• share is deleted ❗
• share mountpoint is lost ❗

[saw-jan]

Recent partial fix: cs3org/reva#4785

Related issues:

• COPY a folder to received share file/folder seems to work but no change in shares - lost share mountpoint in me/drives #6999
• COPY a file to recevied share folder returns 412 Pre condition failed - lost share mountpoint in me/drives #3874

[saw-jan]

CC @kobergj

[kobergj]

@saw-jan Case 1 (File to shared File) is a special case. The 204 No Content is correct here, as it will just create a new version for the existing file. This is expected and wanted behaviour.

All other cases we block. The fix comes with this reva PR: cs3org/reva#4802