API test cases for COPY file between spaces

[S-Panta]

COPY

Similar to #8121

1. Using file id

Test cases

from	from (role)	to	to (role)	expected	result	automated
personal		personal{within same folder}		201	201 👍	✅
personal		personal{inside subfolder}		201	201 👍	✅
personal		personal{from subfolder to root }		201	201 👍	✅
personal		project{finside folder}		201	201 👍	✅
project		personal		201	201 👍	✅
share jail		share jail {from sub-folder to another folder inside share}	Editor	201	201 👍	✅
personal		share jail	Editor	201	201 👍	✅
share jail		personal		201	201 👍	✅
project		project{project spaces within same user}		201	201 👍	✅
project	different permission	share jail	different permission	201	201 👍	✅ #9940
project	different permission	personal		201	201 👍	✅ #9940
project	different permission	project	different permission	201	201 👍	✅ #9940
share jail	different permission	project	different permission	201	201 👍	✅ #9932
share jail	different permission	share jail	different permission	201	201 👍	✅ #9932
share jail	different permission	personal		201	201 👍	✅ #9932

2. Using file path

Test cases

from	from (role)	to	to (role)	expected	result	automated
project		project{both file and folder within folder of shared project space}	Manager and Space Editor	201	201 👍	✅
project		project{within folder of shared project space}	Viewer	403	403 👍	✅
project	Manager/Space Editor	project	Manager/ Space Editor	201	201 👍	✅
project	Manager/ Space Editor	project	viewer	403	403 👍	✅
project	Manager/ Space Editor/ Space Viewer	personal		201	201 👍	✅
project	Manager/ Space Editor/ Space Viewer	share jail(inside folder)	editor	201	201 👍	✅
project	Manager/ Space Editor/ Space Viewer	share jail(inside folder)	viewer	403	403 👍	✅
project	manager/space editor/viewer	project	Manager and Space Editor	201	201 👍	✅
project	manager/space editor/viewer	project	Space Viewer	403	403 👍	✅
project	manager/space editor/viewer	share jail	Editor	201	201 👍	✅
project	manager/space editor/viewer	share jail	viewer	403	403 👍	✅
personal		share jail	viewer	403	403 👍	✅
personal		share jail	Editor(option keep both)	201	201 👍	✅
personal		share jail	Editor(option replace)	204	204	✅
personal		project	Manager/Space editor	201	201 👍	✅
personal		project	viewer	403	403 👍	✅
personal		share jail	Editor	201	201 👍	✅
personal		share jail(overwrites a file)	viewer	403	403 👍	✅
personal		share jail (copy file over existing folder)	Editor	400	400 #7208	✅
personal		share jail (copy folder over existing file)	Editor	400	400	✅ #6323
personal		share jail (copy a folder into another folder at different level)	Editor	204	204 👍	✅
personal		share jail (copy a file into another folder at different level)	Editor	204	204 👍	✅
personal		share jail (copy a file into another file at different level)	Editor	204	204 👍	✅
personal		share jail (copy a folder into another file at different level) (all overwrites scenario are done also for group share)	Editor	204	204 👍	✅
share jail	editor/viewer	personal		201	201 👍	✅
share jail	secure viewer	personal		403	403 👍(#9482)	✅
share jail	editor/ viewer	project	manager/space editor	201	201 👍	✅
share jail	secure viewer	project	manager/space editor	403	403 👍:(#9482)	✅
share jail	editor	project	viewer	403	403 👍	✅
share jail	editor/viewer	share jail ( between different shares)	editor	201	201 👍	✅
share jail	editor/viewer/secure viewer	share jail ( between different shares)	viewer/secure viewer	403	403 👍:(#9482)	✅

Other scenario related to copy

• copying a file with an option "keep both" inside of the project space
• copying a file with an option "replace" inside of the project space
• copy blacklisted file isn't possible.
• copy a file of size zero byte
• copy (existent/non existent file/folder) into (existent/non existent file/folder)
• copying a folder into a sub-folder of itself

Bug Report

• copying a file/folder to itself COPY file/folder to same name is possible (but 500 code error for folder with spaces path) #8711

[S-Panta]

@saw-jan @SagarGi Do we need any extra test cases for copying via file id? I think there are enough cases for copying via path.

[saw-jan]

Please, have a look in these feature files:

• apiSpacesShares/copySpaces.feature
• apiSpacesDavOperation/copyByFileId.feature
• coreApiWebdavProperties/copyFile.feature

[Salipa-Gurung]

The expected status code for the test cases below and the status code in the automated tests does not match ❗

from	from (role)	to	to (role)	expected	result	automated
personal		share jail	Editor(option replace)	201	204 ❔	✅
personal		share jail (copy file over existing folder)	Editor	204	400 ❔ #7208	✅
personal		share jail (copy folder over existing file)	Editor	204	400 ❔	✅ #6323

[saw-jan]

This should be the correct expectation and result

from	from (role)	to	to (role)	expected	result	automated
personal		share jail	Editor(option replace)	204	204	✅
personal		share jail (copy file over existing folder)	Editor	400	400	✅
personal		share jail (copy folder over existing file)	Editor	400	400	✅

• overwrite/replace means updating the file - so 204 is correct
• copy folder to file share is not allowed (400) - Block overwriting mountpoints through COPY cs3org/reva#4785
• copy file to folder share is not allowed (400) - COPY file/folder to share mountpoint: inconsistent behavior between dav paths #9753 (comment)

[saw-jan]

Please, close this issue if you think everything is covered

[Salipa-Gurung]

Once test coverage for the test cases listed below has been confirmed then we can close this issue.

Other scenario related to copy

• copying a file with an option "keep both" inside of the project space

  ocis/tests/acceptance/features/apiSpacesShares/copySpaces.feature

  Line 966 in a5d5620

  Scenario: copying a file with an option "keep both" inside of the project space

• copying a file with an option "replace" inside of the project space

  ocis/tests/acceptance/features/apiSpacesShares/copySpaces.feature

  Line 980 in a5d5620

  Scenario: copying a file with an option "replace" inside of the project space

• copy blacklisted file isn't possible.

  ocis/tests/acceptance/features/coreApiWebdavProperties/copyFile.feature

  Line 96 in a5d5620

  Scenario Outline: copying file to a path with extension .part should not be possible

• copy a file of size zero byte

  ocis/tests/acceptance/features/coreApiWebdavProperties/copyFile.feature

  Line 624 in a5d5620

  Scenario Outline: copy a file of size zero byte

• copy (existent/non existent file/folder) into (existent/non existent file/folder)
  

  ocis/tests/acceptance/features/coreApiWebdavProperties/copyFile.feature

  Line 639 in a5d5620

  Scenario Outline: copy file into a nonexistent folder

  
  

  ocis/tests/acceptance/features/coreApiWebdavProperties/copyFile.feature

  Line 652 in a5d5620

  Scenario Outline: copy a nonexistent file into a folder

  
  

  ocis/tests/acceptance/features/coreApiWebdavProperties/copyFile.feature

  Line 664 in a5d5620

  Scenario Outline: copy a folder into a nonexistent one

• copying a folder into a sub-folder of itself

  ocis/tests/acceptance/features/coreApiWebdavProperties/copyFile.feature

  Line 988 in a5d5620

  Scenario Outline: copying a folder into a sub-folder of itself

Bug Report

• copying a file/folder to itself COPY file/folder to same name is possible (but 500 code error for folder with spaces path) #8711
  

  ocis/tests/acceptance/features/coreApiSharePublicLink2/copyFromPublicLink.feature

  Line 186 in 1ba6e4b

  Scenario: copy file within a public link folder to a same file

  
  

  ocis/tests/acceptance/features/coreApiSharePublicLink2/copyFromPublicLink.feature

  Line 198 in 1ba6e4b

  Scenario: copy folder within a public link folder to a same folder

  
  

  ocis/tests/acceptance/features/coreApiWebdavProperties/copyFile.feature

  Line 1044 in 1ba6e4b

  Scenario Outline: copying a file to itself

  
  

  ocis/tests/acceptance/features/coreApiWebdavProperties/copyFile.feature

  Line 1057 in 1ba6e4b

  Scenario Outline: copying a folder to itself

[anon-pradip]

Since all the test cases have been covered, we can close this. cc @Salipa-Gurung @saw-jan @S-Panta