Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Enhance share copy-overwrite test scenarios #6323

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

phil-davis
Copy link
Contributor

Description

WIP - first see how these test scenarios go on ocis. Then decide what behavior is desired etc.

Related Issue

New and changed test scenarios from core owncloud/core#40308

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@micbar
Copy link
Contributor

micbar commented Jul 8, 2024

@phil-davis Still a thing? Or close?

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the looks of it, we already have these test scenarios. So, maybe we can close this one?
CC @phil-davis

Comment on lines +318 to +320
Scenario Outline: copy a file over the top of an existing file received as a user share
Given using <dav_version> DAV path
And user "Brian" has been created with default attributes and without skeleton files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have this test:

Scenario Outline: copy a file over the top of an existing folder received as a user share

| new |


Scenario Outline: copy a folder over the top of an existing folder received as a user share
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have this test:

Scenario Outline: copy a folder over the top of an existing folder received as a share

@@ -879,3 +945,19 @@ Feature: copy file
Examples:
| dav_version |
| spaces |


Scenario Outline: copying a folder with a file onto another folder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar test scenario:

Scenario Outline: copying a folder with a file into another folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants