make insecure upstream servers configurable #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragotin
reviewed
Dec 3, 2020
proxy/pkg/config/config.go
Outdated
| @@ -106,6 +106,7 @@ type Config struct { | |||
| PreSignedURL PreSignedURL | |||
| AutoprovisionAccounts bool | |||
| EnableBasicAuth bool | |||
| Insecure bool | |||
There was a problem hiding this comment.
Naming: How about rather calling that SkipCertValidation or so?
But this is more in the area of nitpicking - just as you want.
There was a problem hiding this comment.
It is called Insecure everywhere in oCIS:
- PROXY_OIDC_INSECURE
- KONNECTD_INSECURE
- GLAUTH_BACKEND_INSECURE
- STORAGE_OIDC_INSECURE
There was a problem hiding this comment.
I would change it to InsecureBackends to signify what is insecure
IljaN
suggested changes
Dec 3, 2020
IljaN
approved these changes
Dec 3, 2020
wkloucek
force-pushed
the
proxy_allow_insecure_upstreams
branch
from
cbe9817 to
fe2efc3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we can disable certificate verification for the OIDC provider in the proxy. But you can not disable certificate verification for upstream servers defined in the proxy-config.json.
For some situations like testing, it is desirable to turn off certificate verification for upstream servers in the proxy.