fix: return 404 code if file isn't found on CheckFileInfo request #10112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
kobergj
approved these changes
Sep 20, 2024
ownclouders
pushed a commit
that referenced
this pull request
Sep 20, 2024
…rror_code fix: return 404 code if file isn't found on CheckFileInfo request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
CheckFileInforequest will now return a 404 error code if the target file isn't foundRelated Issue
#10097
Motivation and Context
Server should return a proper error code instead of a generic 500
How Has This Been Tested?
Manually tested following steps in #10097 , and unit tests added for this specific case
Screenshots (if appropriate):
Types of changes
Checklist: