Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] address Gtw selector sonarcloud complaints #10141

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

butonic
Copy link
Member

@butonic butonic commented Sep 23, 2024

address sonarcloud complaints from #10133 that got merged early

Copy link

update-docs bot commented Sep 23, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic changed the title Gtw selector address Gtw selector sonarcloud complaints Sep 23, 2024
@butonic butonic requested a review from micbar September 23, 2024 15:26
@butonic butonic changed the title address Gtw selector sonarcloud complaints [full-ci] address Gtw selector sonarcloud complaints Sep 23, 2024
@micbar
Copy link
Contributor

micbar commented Sep 24, 2024

Unit test fails

• [FAILED] [0.001 seconds]
ContentConnector PutFile [It] Missing upload endpoint
/drone/src/services/collaboration/pkg/connector/contentconnector_test.go:389

  [FAILED] Unexpected error:
      <*connector.ConnectorError | 0xc000b43098>: 
      url is missing
      {
          HttpCodeOut: 500,
          Msg: "url is missing",
      }
  occurred
  In [It] at: /drone/src/services/collaboration/pkg/connector/contentconnector_test.go:409 @ 09/23/24 15:39:28.741
------------------------------
••

Summarizing 1 Failure:
  [FAIL] ContentConnector PutFile [It] Missing upload endpoint
  /drone/src/services/collaboration/pkg/connector/contentconnector_test.go:409

@butonic
Copy link
Member Author

butonic commented Sep 24, 2024

ah ... it needs a json payload ...

@butonic butonic force-pushed the gtw-selector branch 2 times, most recently from 9bcbecd to 0a6873f Compare September 25, 2024 14:55
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Copy link

sonarcloud bot commented Sep 26, 2024

@butonic butonic merged commit ef15a63 into master Sep 26, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request Sep 26, 2024
[full-ci] address Gtw selector sonarcloud complaints
@butonic butonic deleted the gtw-selector branch September 26, 2024 15:33
@micbar micbar mentioned this pull request Oct 1, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants