fix issue ocis-1043 in settings service #1044
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| @@ -107,8 +108,8 @@ export default { | |||
| getExtensionName (extension) { | |||
| extension = extension || '' | |||
| switch (extension) { | |||
| case 'ocis-accounts': return this.$gettext('Account') | |||
| case 'ocis-hello': return this.$gettext('Hello') | |||
| case 'ocis-accounts': return 'Account' | |||
There was a problem hiding this comment.
The this.$gettext is needed. Otherwise the strings will not be extracted for translation (submission to transifex).
| :key="'bundle-' + bundle.id" | ||
| :bundle="bundle" | ||
| class="oc-mt" | ||
| v-for="bundle in selectedBundles" |
There was a problem hiding this comment.
The indentation looks wrong here and in the next three lines 🤔
There was a problem hiding this comment.
dang, my formatter haven't picked this up... done in new commit.
| initialized () { | ||
| this.resetMenuItems() | ||
| this.resetSelectedExtension() | ||
| '$language.current': { |
There was a problem hiding this comment.
I fear that this is needed for now. But it looks and feels wrong that extensions have to watch on the language themselves. Only oC web core should be responsible for triggering translation updates on language changes. 🤔
There was a problem hiding this comment.
yea, no separation of concerns. I pick thist up for our improvement paper
|
Kudos, SonarCloud Quality Gate passed!
|
partially fixes #1043