fix: use a tmp file and rename to prevent a possible race condition #10693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
@jvillafanez pls dont forget to add a changelog 😃 |
rhafer
suggested changes
Dec 2, 2024
|
@jp it would be great if all open issues get fixed so this could go into v7 |
jvillafanez
force-pushed
the
thumbnails_fix_fs_race
branch
from
96ed740 to
f3d91f8
Compare
|
code should be ready now, assuming the tests pass |
rhafer
approved these changes
Dec 3, 2024
|
ownclouders
pushed a commit
that referenced
this pull request
Dec 3, 2024
fix: use a tmp file and rename to prevent a possible race condition
This was referenced Dec 9, 2024
Closed
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a temporary file and then rename in order to prevent a race condition. This should help to prevent getting thumbnails with 0 byte content or with partial content.
According to the documentation, the won't be name collisions in the FS with the temporary files, so every thumbnail will be written into a unique file before trying to rename it to the final file (0 byte or partial content shouldn't happen).
NOTE: The previous
os.Createcall creates a file with 0666 permissions. The newos.CreateTempcreates the file with 0600 permissions, so the new thumbnails will have different permissions on the FS. This shouldn't cause problems though.Related Issue
#10684
Motivation and Context
This increases the stability of the system by preventing the error from happening.
How Has This Been Tested?
Basic case has been tested manually to ensure the code doesn't break anything.
Error reproduction is very difficult because it's a race condition, but the error message should clarify what's happening.
Screenshots (if appropriate):
Types of changes
Checklist: