Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] bump reva #10879

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[full-ci] bump reva #10879

wants to merge 1 commit into from

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Jan 15, 2025

Description

The ocis module version is v2 instead of v7 in a go.mod file it broke the dependencies between the osic and reva
There are several services in a reva that use github.com/owncloud/ocis/v2/ocis-pkg/registry and pointed to the ocis/v2.0.0
https://github.com/cs3org/reva/blob/ea319ad6ac575eb725be92f9c0be8a6f7fe84fbd/go.mod#L64

It could lead to unexpected side effects because the default registry for the v2 is mdnsr

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Jan 15, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@2403905 2403905 changed the title fix the ocis module version accordingly to the major version [full-ci] bump reva Jan 15, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ocis module version is v2 instead of v7
1 participant