Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update reva #1089

Merged
merged 1 commit into from
Dec 14, 2020
Merged

update reva #1089

merged 1 commit into from
Dec 14, 2020

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Dec 14, 2020

update reva

@C0rby C0rby requested review from IljaN, butonic, kulmann and refs December 14, 2020 10:11
@C0rby C0rby self-assigned this Dec 14, 2020
@update-docs
Copy link

update-docs bot commented Dec 14, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

kulmann
kulmann suggested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misses a changelog. Also, could you run ocis server once, so that all the other go.sum files get updated regarding reva and cs3 apis, and add that to this PR as well?

@C0rby
Copy link
Contributor Author

C0rby commented Dec 14, 2020

Misses a changelog. Also, could you run ocis server once, so that all the other go.sum files get updated regarding reva and cs3 apis, and add that to this PR as well?

I already did a make clean build so the other go.sum files should be up-to-date.
Added a changelog.

@C0rby C0rby requested a review from kulmann December 14, 2020 12:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kulmann
kulmann approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@C0rby C0rby merged commit eecdadb into master Dec 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-reva branch December 14, 2020 13:11
ownclouders pushed a commit that referenced this pull request Dec 14, 2020
@C0rby
commit eecdadb
b939296 
Merge: 1456898 b60eece
Author: David Christofas <C0rby@users.noreply.github.com>
Date:   Mon Dec 14 14:11:48 2020 +0100

    Merge pull request #1089 from owncloud/update-reva

    update reva
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@IljaN IljaN Awaiting requested review from IljaN

@butonic butonic Awaiting requested review from butonic

@refs refs Awaiting requested review from refs

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C0rby @kulmann