[tests-only][full-ci] adding test for creating auth-app token using user-id #10987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
nirajacharya2
force-pushed
the
create-auth-app-usr-id
branch
2 times, most recently
from
16e920f to
8e69a5f
Compare
nirajacharya2
requested review from
phil-davis,
anon-pradip,
saw-jan,
prashant-gurung899,
amrita-shrestha,
nabim777 and
PrajwolAmatya
nirajacharya2
force-pushed
the
create-auth-app-usr-id
branch
from
8e69a5f to
fe623a9
Compare
nirajacharya2
force-pushed
the
create-auth-app-usr-id
branch
from
fe623a9 to
d8361a3
Compare
amrita-shrestha
requested changes
Feb 25, 2025
nirajacharya2
force-pushed
the
create-auth-app-usr-id
branch
from
d8361a3 to
2733ec0
Compare
nirajacharya2
force-pushed
the
create-auth-app-usr-id
branch
2 times, most recently
from
348c7f3 to
c511739
Compare
saw-jan
reviewed
Feb 26, 2025
Comment on lines
+260
to
+272
| Given the config "AUTH_APP_ENABLE_IMPERSONATION" has been set to "true" | ||
| And user "Brian" has been created with default attributes | ||
| When user "Brian" creates app token with user-id for user "Alice" with expiration time "72h" using the auth-app API | ||
| Then the HTTP status code should be "403" | ||
|
|
||
| @issue-11063 | ||
| Scenario: non-admin user tries to creates auth-app token with user-id for an another user without impersonation enabled |
There was a problem hiding this comment.
same needs to be done for username as well. check if they exist or not.
also please update all of them in the QA ticket.
There was a problem hiding this comment.
There was a problem hiding this comment.
just make sure the similar test scenarios exist while using username as well
nirajacharya2
force-pushed
the
create-auth-app-usr-id
branch
2 times, most recently
from
3397edf to
d6c32e8
Compare
nirajacharya2
requested review from
PrajwolAmatya,
saw-jan and
prashant-gurung899
nirajacharya2
force-pushed
the
create-auth-app-usr-id
branch
2 times, most recently
from
3d63142 to
5a9f79f
Compare
nirajacharya2
force-pushed
the
create-auth-app-usr-id
branch
from
5a9f79f to
dccdbf7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test for creating auth-app token using user-id
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: