[tests-only][full-ci]added test for user trying to accept federation share invitation from same instance #11015
Conversation
PrajwolAmatya
force-pushed
the
test-for-issue-11004
branch
from
24fab4a to
3228a17
Compare
PrajwolAmatya
requested review from
anon-pradip,
ishabaral,
saw-jan,
prashant-gurung899,
Salipa-Gurung,
amrita-shrestha,
nabim777,
S-Panta and
nirajacharya2
PrajwolAmatya
force-pushed
the
test-for-issue-11004
branch
from
3228a17 to
b470fad
Compare
| @@ -178,6 +178,29 @@ public function userHasAcceptedTheLastFederationShareInvitation(string $user): v | |||
| $this->featureContext->theHTTPStatusCodeShouldBe(200, '', $response); | |||
| } | |||
|
|
|||
| /** | |||
| * @When :user tries to accept the federation share invitation from same instance | |||
There was a problem hiding this comment.
Do we really need this step?
How about using this step or modiying it, rather than adding a new step?
There was a problem hiding this comment.
Within this step we want to set the value of providerDomain with the domain of the same instance.
The providerDomain takes the value of domain of the other instance to create federated connection, for instance when using LOCAL server, i.e. localhost:9200, the providerDomain should have value of remote domain localhost:10200.
In existing step we cannot specify providerDomain of same instance. To modify the existing step we some how need to make the providerDomain to take the domain of same instance. And the existing step is written such that the providerDomain takes the domain of the other instance.
So, had to create a new step.
| "const": "ALREADY_EXIST" | ||
| }, | ||
| "message": { | ||
| "const": "user already known" |
There was a problem hiding this comment.
i am just curious what happens when we have user with same credentials in both instance and tries to accept invitation between the identical user in different instance
There was a problem hiding this comment.
For that case, the users in two instances are differentiated via providerDomain. So, there will not be any issues for the federation connection.
There was a problem hiding this comment.
and whats the message?
There was a problem hiding this comment.
For successful connection it doesn't return any message. Messages are returned only for invalid cases.
PrajwolAmatya
force-pushed
the
test-for-issue-11004
branch
from
b470fad to
a1f87b5
Compare
|
| @@ -178,6 +178,29 @@ public function userHasAcceptedTheLastFederationShareInvitation(string $user): v | |||
| $this->featureContext->theHTTPStatusCodeShouldBe(200, '', $response); | |||
| } | |||
|
|
|||
| /** | |||
| * @When :user tries to accept the federation share invitation from same instance | |||
|
LGTM 👍 |
[tests-only][full-ci]added test for user trying to accept federation share invitation from same instance
Description
This PR adds API test for a user trying to accept federation share invitation from same instance.
Related Issue
Types of changes
Checklist: