Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add test to hide federated shared resource #11024

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

prashant-gurung899
Copy link
Contributor

Description

This PR adds test to hide federated shared resource.

Scenario: federated user hides the shared resource

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 force-pushed the test/hide-unhide-ocm-shares branch from 4642a76 to a01b55a Compare February 20, 2025 05:57
@prashant-gurung899 prashant-gurung899 force-pushed the test/hide-unhide-ocm-shares branch 3 times, most recently from d4ce85f to 4b98c51 Compare February 21, 2025 06:22
Copy link
Member

@nabim777 nabim777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -1189,3 +1189,51 @@ Feature: an user shares resources using ScienceMesh application
And user "Brian" should not have a federated share "folderToShare" shared by user "Alice" from space "Personal"
And using server "LOCAL"
And as "Alice" file "folderToShare/file.txt" should not exist

@issue-10719
Scenario: federated user hides the file shared by local user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can cover two scenarios into a single Scenario Outline.

Copy link
Contributor

@amrita-shrestha amrita-shrestha Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping separate should be fine

@@ -1189,3 +1189,51 @@ Feature: an user shares resources using ScienceMesh application
And user "Brian" should not have a federated share "folderToShare" shared by user "Alice" from space "Personal"
And using server "LOCAL"
And as "Alice" file "folderToShare/file.txt" should not exist

@issue-10719
Scenario: federated user hides the file shared by local user
Copy link
Contributor

@amrita-shrestha amrita-shrestha Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping separate should be fine

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prashant-gurung899 prashant-gurung899 force-pushed the test/hide-unhide-ocm-shares branch from 6f62535 to 4bde4fa Compare February 27, 2025 04:53
Signed-off-by: prashant-gurung899 <prasantgrg777@gmail.com>
@prashant-gurung899 prashant-gurung899 merged commit 47e9aff into master Feb 28, 2025
4 checks passed
@prashant-gurung899 prashant-gurung899 deleted the test/hide-unhide-ocm-shares branch February 28, 2025 04:02
ownclouders pushed a commit that referenced this pull request Feb 28, 2025
[tests-only][full-ci] add test to hide federated shared resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants