-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MICRO_REGISTRY_ADDRESS env var for etcd address #1546
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + Tested 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't this be replaced by following?
func newGrpcClient() mclient.Client {
r := *registry.GetRegistry()
c := grpc.NewClient(
mclient.RequestTimeout(10*time.Second),
mclient.Registry(r),
)
return c
}
Yes, it seems cleaner. I'll test it right away |
Used test steps:
run oCIS:
Try to log in on the web UI. Fails before this fix and works after this fix. |
@ybr-nx Could you please add a change log in the folder My proposal:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution!
@ybr-nx sorry that I need to come back to you again. Can you rebase your current branch or merge our master branch back to your branch? We had some big changes our master branch which caused that this PR can not be merged in the current state. |
The following link does no exist [our repository](https://github.com/owncloud/ocis/tree/master/config),
Kudos, SonarCloud Quality Gate passed! |
Description
MICRO_REGISTRY_ADDRESS
used only inocis-pkg/registry/registry
and not here. It tried to connect to 127.0.0.1 instead.