Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quickfix for thumbnail generation when using different idp #1628

Merged
merged 3 commits into from
Feb 12, 2021
Merged

quickfix for thumbnail generation when using different idp #1628

merged 3 commits into from
Feb 12, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Feb 11, 2021

Implemented a quickfix for generating thumbnails in a setup when a different idp than konnectd is used.
This is just a quick fix and the thumbnail service will be refactored in the near future.

@C0rby C0rby requested review from butonic and refs February 11, 2021 14:55
@C0rby C0rby self-assigned this Feb 11, 2021
wkloucek
wkloucek approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with a Keycloak setup

@butonic
Copy link
Member

butonic commented Feb 11, 2021

@C0rby the protobuf tests now render with two spaces? wtf https://drone.owncloud.com/owncloud/ocis/3356/13/6

@C0rby
Copy link
Contributor Author

C0rby commented Feb 11, 2021

@C0rby the protobuf tests now render with two spaces? wtf https://drone.owncloud.com/owncloud/ocis/3356/13/6

Yeah WTF...
Anyway I deleted that test file. I don't see any value provided by that

@wkloucek wkloucek mentioned this pull request Feb 11, 2021
Merged
9 tasks
@wkloucek
Copy link
Contributor

@C0rby I think we should try to get it merged before 1.2.0 release. What do you think?

@C0rby
Copy link
Contributor Author

C0rby commented Feb 12, 2021

Yes, I agree

@sonarcloud
Copy link

sonarcloud bot commented Feb 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@C0rby C0rby merged commit eefd6a5 into master Feb 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the thumbnail-refactor branch February 12, 2021 13:30
ownclouders pushed a commit that referenced this pull request Feb 12, 2021
@C0rby
commit eefd6a5
2a244d5 
Merge: 67f9f1f 8c9a171
Author: David Christofas <C0rby@users.noreply.github.com>
Date:   Fri Feb 12 14:30:06 2021 +0100

    Merge pull request #1628 from owncloud/thumbnail-refactor

    quickfix for thumbnail generation when using different idp
wkloucek added a commit to owncloud-devops/ocis-team-ocis that referenced this pull request Feb 12, 2021
@wkloucek
include owncloud/ocis#1628
46c5048
@butonic butonic mentioned this pull request Feb 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

@butonic butonic Awaiting requested review from butonic

@refs refs Awaiting requested review from refs

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@C0rby @butonic @wkloucek