Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] add breaking changes and migration #1679

Merged
merged 1 commit into from
Feb 18, 2021
Merged

[docs-only] add breaking changes and migration #1679

merged 1 commit into from
Feb 18, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Feb 18, 2021 •
edited
Loading

Description

Prominently add breaking changes to oCIS 1.2.0 changelog and show migrations

Related Issue

Motivation and Context

Users should be able to migrate from pre 1.2.0 to 1.2.0

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • copy changes to GitHub Releases change log after merging this

@update-docs
Copy link

update-docs bot commented Feb 18, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

pmaier1
pmaier1 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX 👍

@phil-davis phil-davis merged commit 74c883b into master Feb 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the add_breaking_changes_changelog branch February 18, 2021 11:35
ownclouders pushed a commit that referenced this pull request Feb 18, 2021
@phil-davis
commit 74c883b
d4aba71 
Merge: ebc51c6 977f590
Author: Phil Davis <phil@jankaritech.com>
Date:   Thu Feb 18 14:35:37 2021 +0300

    Merge pull request #1679 from owncloud/add_breaking_changes_changelog

    [docs-only] add breaking changes and migration
@wkloucek
Copy link
Contributor Author

@micbar can you add the changes to the GitHub Release Notes please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@pmaier1 pmaier1 pmaier1 approved these changes

@micbar micbar Awaiting requested review from micbar

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot login after PR #1390
3 participants
@wkloucek @phil-davis @pmaier1