Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace special character in login page title with a regular minus #1813

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Replace special character in login page title with a regular minus #1813

merged 1 commit into from
Mar 17, 2021

Conversation

JammingBen
Copy link
Contributor

This change is required to match the title naming convention introduced in owncloud/web#4811

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen self-assigned this Mar 16, 2021
@JammingBen JammingBen added the Category:Enhancement Add new functionality label Mar 16, 2021
kulmann
kulmann approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 2fe3ffb into master Mar 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/login-page-title branch March 17, 2021 08:46
ownclouders pushed a commit that referenced this pull request Mar 17, 2021
@JammingBen
commit 2fe3ffb
e77694a 
Merge: 0d5ac2e bfcab42
Author: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
Date:   Wed Mar 17 09:46:34 2021 +0100

    Merge pull request #1813 from owncloud/issues/login-page-title

    Replace special character in login page title with a regular minus
@fschade fschade mentioned this pull request Mar 29, 2021
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann kulmann approved these changes

Assignees

@JammingBen JammingBen

Labels
Category:Enhancement Add new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @kulmann @AlexAndBear