Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Tracing Locig #1819

Merged
merged 26 commits into from
Mar 26, 2021
Merged

Refactor Tracing Locig #1819

merged 26 commits into from
Mar 26, 2021

Conversation

refs
Copy link
Member

@refs refs commented Mar 18, 2021 •
edited
Loading

Essentially, what?

  • refactor the infamous if cfg.Tracing.Enabled guard away due to its verbosity
  • remove unnecessary blocks that interfere with readability
  • inline function calls

@update-docs
Copy link

update-docs bot commented Mar 18, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@refs refs self-assigned this Mar 18, 2021
refs added 19 commits March 18, 2021 11:36
@refs refs marked this pull request as ready for review March 26, 2021 10:37
@refs refs requested a review from LukasHirt as a code owner March 26, 2021 10:37
@refs refs changed the title Refactor tracing and config logic across extensions Refactor Tracing Locig Mar 26, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 26, 2021

SonarCloud Quality Gate failed.

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
74.2% 74.2% Duplication

@refs refs merged commit 95b69a5 into master Mar 26, 2021
@refs refs deleted the refactor-extensions branch March 26, 2021 12:01
ownclouders pushed a commit that referenced this pull request Mar 26, 2021
@refs
commit 95b69a5
ffaaee1 
Merge: ed8d850 c5bef36
Author: Alex Unger <6905948+refs@users.noreply.github.com>
Date:   Fri Mar 26 13:01:35 2021 +0100

    Merge pull request #1819 from owncloud/refactor-extensions
@fschade fschade mentioned this pull request Mar 29, 2021
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

Assignees

@refs refs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refs @butonic