Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime port and host configurable #1822

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Runtime port and host configurable #1822

merged 3 commits into from
Mar 18, 2021

Conversation

refs
Copy link
Member

@refs refs commented Mar 18, 2021

What?

Without any configuration the ocis runtime will start on localhost:6060 unless specified otherwise. Usage:

  • OCIS_RUNTIME_PORT=6061 bin/ocis server
    • overrides the oCIS runtime and starts on port 6061
  • OCIS_RUNTIME_PORT=6061 bin/ocis list
    • lists running extensions for the runtime on localhost:6061

All subcommands are updated and expected to work with the following environment variables:

OCIS_RUNTIME_HOST
OCIS_RUNTIME_PORT

@refs refs requested a review from butonic March 18, 2021 14:28
@refs refs self-assigned this Mar 18, 2021
@butonic
Copy link
Member

butonic commented Mar 18, 2021

maybe pick a default port from the FREE list: https://github.com/owncloud/ocis/wiki/Official-Port-Ranges

@refs
Copy link
Member Author

refs commented Mar 18, 2021

maybe pick a default port from the FREE list: owncloud/ocis/wiki/Official-Port-Ranges

done, picked 9250

@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
39.5% 39.5% Duplication

@refs refs merged commit d183cdb into master Mar 18, 2021
@refs refs deleted the runtime-hostname-port-configurable branch March 18, 2021 16:36
ownclouders pushed a commit that referenced this pull request Mar 18, 2021
@refs
commit d183cdb
1deb4b7 
Merge: 29897ca 61a15be
Author: Alex Unger <6905948+refs@users.noreply.github.com>
Date:   Thu Mar 18 17:36:33 2021 +0100

    Merge pull request #1822 from owncloud/runtime-hostname-port-configurable
@fschade fschade mentioned this pull request Mar 29, 2021
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

Assignees

@refs refs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refs @butonic