Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use binaries from make release for docker builds #1941

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Apr 20, 2021

Description

Use the same build for the oCIS binary which is added to our docker images like for our our binary releases.

Related Issue

Motivation and Context

enable oCIS docker images to be run on ARM64 devices, in this case Raspberry PI 4. Currently this does not work because of some segfault.

In contrast to that the binary release will run without segfault on the same device.

@update-docs
Copy link

update-docs bot commented Apr 20, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek changed the title use binaries from make release use binaries from make release for docker builds Apr 20, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek linked an issue Apr 20, 2021 that may be closed by this pull request
@wkloucek wkloucek marked this pull request as ready for review April 21, 2021 09:31
@wkloucek wkloucek requested a review from refs April 21, 2021 09:32
@refs refs merged commit a95cf43 into master Apr 21, 2021
@refs refs deleted the fix_arm64_builds_docker branch April 21, 2021 09:40
ownclouders pushed a commit that referenced this pull request Apr 21, 2021
Merge: dff3f0a 0e36f04
Author: Alex Unger <6905948+refs@users.noreply.github.com>
Date:   Wed Apr 21 11:40:05 2021 +0200

    Merge pull request #1941 from owncloud/fix_arm64_builds_docker

    use binaries from make release for docker builds
This was referenced Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image segfaults on Raspberry Pi 4B 64-bit
2 participants