Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Run web UI ocisSmokeTest scenarios in a single pipeline #2093

Merged
merged 1 commit into from
May 28, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 27, 2021

Description

This PR runs just the owncloud/web UI tests tagged ocisSmokeTest in a single pipeline. The full set of web UI tests are run in the owncloud/web repo. Here we just run the smoketests to have confidence that the web client "built in" with OCIS is in a working state.

For this PR, we still need to list all the test suites to be run. Next, we can enhance the run.sh in owncloud/web so that it can scan all the suites itself to run everything in a single pipeline.

Related Issue

Motivation and Context

Eliminate unnecessary test runs in CI

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this May 27, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 27, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/ocis/5159/43/6
17 scenarios (17 passed)
2m15.340s

The whole pipeline took about 5 minutes. Other acceptance test pipelines are taking 10 to 15 minutes.

That's good. We could merge this PR, and also review the web test scenarios that are tagged ocisSmokeTest - there will be no problem adding a few more if that seems appropriate.

@phil-davis phil-davis marked this pull request as ready for review May 27, 2021 13:51
@phil-davis phil-davis merged commit bde661f into master May 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the run-only-ocisSmokeTest branch May 28, 2021 10:43
ownclouders pushed a commit that referenced this pull request May 28, 2021
Merge: a01e3a7 6bf1652
Author: Phil Davis <phil@jankaritech.com>
Date:   Fri May 28 16:28:07 2021 +0545

    Merge pull request #2093 from owncloud/run-only-ocisSmokeTest

    [tests-only] Run web UI ocisSmokeTest scenarios in a single pipeline
@phil-davis
Copy link
Contributor Author

I raised issue owncloud/web#5167 to review the web smoke test scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants