Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Bump core and web commit id #2206

Merged
merged 1 commit into from
Jun 23, 2021
Merged

[full-ci] [tests-only] Bump core and web commit id #2206

merged 1 commit into from
Jun 23, 2021

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jun 23, 2021 •
edited
Loading

Description

Bumped commit IDs of core to get the latest core API test scenarios

part of owncloud/QA#662

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Jun 23, 2021
@saw-jan saw-jan mentioned this pull request Jun 23, 2021
Closed
3 tasks
@phil-davis
Copy link
Contributor

If PR #2205 passes CI and gets merged soon, then please rebase this PR so that we run all the tests with the latest code that is imported from reva into OCIS.

@saw-jan
Copy link
Member Author

saw-jan commented Jun 23, 2021

If PR #2205 passes CI and gets merged soon, then please rebase this PR so that we run all the tests with the latest code that is imported from reva into OCIS.

Sure!!

@phil-davis
Copy link
Contributor

Note: CI passed a few hours ago here: https://drone.owncloud.com/owncloud/ocis/5563

The PR has now been rebased. I expect it will pass again!

@phil-davis phil-davis self-requested a review June 23, 2021 13:09
@phil-davis phil-davis marked this pull request as ready for review June 23, 2021 13:10
@phil-davis
Copy link
Contributor

Similar reva PR is cs3org/reva#1816

@phil-davis phil-davis changed the title [tests-only] Bump core commit id [tests-only] Bump core and web commit id Jun 23, 2021
kulmann
kulmann approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-davis phil-davis changed the title [tests-only] Bump core and web commit id [full-ci] [tests-only] Bump core and web commit id Jun 23, 2021
@phil-davis
Copy link
Contributor

Note: I will let the current CI finish - that is doing a "minimal" CI with just the web smoke tests. Then I will restart it to get a full run of web tests (I added "full-ci" to the title)

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 3c92932 into master Jun 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the bump-commit-ids branch June 23, 2021 17:36
ownclouders pushed a commit that referenced this pull request Jun 23, 2021
@phil-davis
commit 3c92932
df01037 
Merge: 88587af 28a6e7b
Author: Phil Davis <phil@jankaritech.com>
Date:   Wed Jun 23 23:21:48 2021 +0545

    Merge pull request #2206 from owncloud/bump-commit-ids

    [full-ci] [tests-only] Bump core and web commit id
@phil-davis phil-davis mentioned this pull request Jun 24, 2021
Merged
9 tasks
@Talank Talank mentioned this pull request Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@phil-davis phil-davis phil-davis approved these changes

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saw-jan @phil-davis @kulmann