Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deployment examples] simplify traefik configuration #2306

Merged
merged 6 commits into from
Jul 29, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jul 15, 2021

Description

  • Simplifies the deployment example by using a global http to https redirect.

During testing and changing the configuration a few things popped up and have been fixed / changed, too:

  • Removes the "owncloud10_with_oc_web" example. This is outdated since we have the ownCloud Web app for ownCloud 10 and the Web sidecar docker image (https://hub.docker.com/r/owncloud/web). Parts of the example have been prepared to demonstrate the migration, but it was neither working nor documented. An migration example will be added in add migration deployment #2302
  • fix login with ldap example by setting the cn to the username
  • remove idp from the keycloak example because it will never be used in that case
  • fix access to the minio console in the S3 example deployment

Related Issue

  • none

Motivation and Context

Simplify the deployment example

How Has This Been Tested?

  • on dev machine by running docker-compse up -d in the respective deployment example directory

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jul 15, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek force-pushed the simplify_traefik_configuration branch from 1d8eca5 to 2bdb522 Compare July 15, 2021 09:01
@wkloucek wkloucek changed the title [CI skip] simplify traefik configuration [deployment examples] simplify traefik configuration Jul 15, 2021
@wkloucek wkloucek force-pushed the simplify_traefik_configuration branch from af6cd1b to a3fb9a4 Compare July 15, 2021 10:00
@wkloucek wkloucek marked this pull request as ready for review July 15, 2021 10:00
@wkloucek wkloucek requested review from C0rby and refs July 15, 2021 10:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek requested a review from micbar July 21, 2021 16:38
@wkloucek
Copy link
Contributor Author

@micbar can I have a review please? :-)

@micbar micbar merged commit 480d57b into master Jul 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the simplify_traefik_configuration branch July 29, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants