Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] update reva to 4f819b44e544 #2334

Merged
merged 4 commits into from
Jul 30, 2021
Merged

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jul 29, 2021

No description provided.

@update-docs
Copy link

update-docs bot commented Jul 29, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek marked this pull request as draft July 29, 2021 10:15
@wkloucek wkloucek force-pushed the update_reva_4f819b44e544 branch 2 times, most recently from 158f58a to 76a7bb8 Compare July 29, 2021 12:58
@phil-davis
Copy link
Contributor

phil-davis commented Jul 30, 2021

https://drone.owncloud.com/owncloud/ocis/6148/45/6

runsh: Total unexpected failed scenarios throughout the test run:
webUIRenameFiles/renameFiles.feature:129
webUIRenameFiles/renameFiles.feature:128
webUIRenameFolders/renameFolders.feature:118
webUIRenameFolders/renameFolders.feature:117
runsh: There were no unexpected success.

Those are the scenarios that rename a file or folder to a name that contains a backslash \

In this PR, the API tests for that are removed from expected failures: apiWebdavMove1/moveFolder.feature:*

Those API tests expect that renaming to a name containing a backslash will give a 400 response and fail. That now happens on both oC10 and OCIS (and reva).

The web tests are actually a wrong expectation and already are tagged @skipOnOC10 ! I suggest that we:

  1. add them to expected-failures in this PR. That will make CI green.
  2. merge this PR
  3. adjust the tests in owncloud/web to test for the desired behavior (and those tests will start passing against the "new OCIS" when this OCIS PR has been merged)
  4. bump the web commit id in OCIS so that we start using the newer web tests (and we should be removing these web tests from expected failures)

@phil-davis
Copy link
Contributor

phil-davis commented Jul 30, 2021

There are conflicts - how did that happen? :(

Answer: PR #2336 was merged.

@wkloucek wkloucek force-pushed the update_reva_4f819b44e544 branch 4 times, most recently from 3d58bc3 to 271389f Compare July 30, 2021 12:06
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis marked this pull request as ready for review July 30, 2021 13:38
@phil-davis phil-davis merged commit ad0e7fe into master Jul 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the update_reva_4f819b44e544 branch July 30, 2021 13:42
@phil-davis
Copy link
Contributor

Note: there will likely be more changes/fixes coming from cs3org/reva and we will do a full changelog when the final full set of changes are known.

ownclouders pushed a commit that referenced this pull request Jul 30, 2021
Merge: 8703b09 92e7e1b
Author: Phil Davis <phil@jankaritech.com>
Date:   Fri Jul 30 19:27:28 2021 +0545

    Merge pull request #2334 from owncloud/update_reva_4f819b44e544

    [full-ci] update reva to 4f819b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants