Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow overriding the cookie based route by claim #2508

Merged
merged 2 commits into from
Sep 15, 2021
Merged

allow overriding the cookie based route by claim #2508

merged 2 commits into from
Sep 15, 2021

Conversation

butonic
Copy link
Member

@butonic butonic commented Sep 15, 2021

When determining the routing policy we now let the claim override the cookie so that users are routed to the correct backend after login.

needed for #2302
plays together with owncloud/openidconnect#18

@butonic
allow overriding the cookie based route by claim
3d4ee19 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested a review from wkloucek September 15, 2021 09:57
kulmann
kulmann approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@butonic butonic merged commit c53b5bf into master Sep 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the proxy-policy-claim-precedence branch September 15, 2021 11:53
ownclouders pushed a commit that referenced this pull request Sep 15, 2021
@butonic
commit c53b5bf
5828b74 
Merge: b0f0d6a b2d53b9
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Wed Sep 15 13:53:41 2021 +0200

    Merge pull request #2508 from owncloud/proxy-policy-claim-precedence

    allow overriding the cookie based route by claim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butonic @kulmann @wkloucek