Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use buf tooling #2630

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Use buf tooling #2630

merged 1 commit into from
Oct 18, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Oct 15, 2021 •
edited
Loading

Description

Usebufbuild/Buf to:

  • pin dependencies
  • define build output

Related Issue

Motivation and Context

I removed the third_party folder in #2616 and replaced it with a go get because I needed newer proto definitions. This is not great, because the version is no longer pinned. This PR resolves this.

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek marked this pull request as ready for review October 18, 2021 05:50
@wkloucek wkloucek requested review from refs, C0rby and kobergj and removed request for lookacat, kulmann and pascalwengerter October 18, 2021 05:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit 8fdaa18 into master Oct 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the use_buf_tooling branch October 18, 2021 07:20
ownclouders pushed a commit that referenced this pull request Oct 18, 2021
@wkloucek
commit 8fdaa18
332e124 
Merge: 3f25821 367ea73
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon Oct 18 09:20:26 2021 +0200

    Merge pull request #2630 from owncloud/use_buf_tooling

    Use buf tooling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@refs refs Awaiting requested review from refs

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @kobergj