Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC][tests-only] Acceptance tests for parallel deployment #2828

Closed
wants to merge 2 commits into from
Closed

[POC][tests-only] Acceptance tests for parallel deployment #2828

wants to merge 2 commits into from

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Nov 29, 2021 •
edited
Loading

Description

Related Issue

#2387

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Nov 29, 2021
@saw-jan saw-jan force-pushed the parallel-deploy-tests-poc branch 3 times, most recently from e6f39f7 to 2589c22 Compare November 30, 2021 04:17
@phil-davis
Copy link
Contributor

"something happened" to the rebase - 475 files changed!

@saw-jan saw-jan force-pushed the parallel-deploy-tests-poc branch 11 times, most recently from a3f6813 to 1f233fa Compare December 6, 2021 10:10
@saw-jan saw-jan force-pushed the parallel-deploy-tests-poc branch 13 times, most recently from ecca46b to 74941ea Compare December 10, 2021 06:47
@saw-jan
[POC] Tests for parallel deployment
ce51bb7 
add owncloud-selector cookie

working tests

remove unused files

build ocis from source branch

check users in ldap, oc10 and ocis

update proxy config

use ocis selector initially

build ocis from source

use ocis latest image

buil ocis from source

refactor

fix test run script

user 33 and alpine image for ocis server

delete local compose files

run tests with ocis latest
@saw-jan
refactor drone config [volumes]
957151b
@saw-jan saw-jan force-pushed the parallel-deploy-tests-poc branch from 74941ea to 957151b Compare December 13, 2021 06:56
@phil-davis
Copy link
Contributor

@saw-jan and I just had a talk about this. It is good that some actual test scenarios are passing! 👍 We need to leave this branch alone as a demonstration that this works. (We want to be able to see the code here as we refactor)

Now the code needs to be sorted out. A lot of test step and test helper code has been copied across from owncloud/core as PoC. The local API tests here in oCIS are using env var PATH_TO_CORE and that is used in Makefile to use the run.sh script from core and to make the existing test step and test helper code from core available to the test runner. So the parallel deployment code needs to be refactored to to similar.

  • make a PR to core for anything that needs to be modified in the core test helpers and/or test step code (maybe that needs to support some optional header(s) being passed around to choose "oc10" or "ocis" in requests, etc.)
  • make a branch here in oCIS (maybe branch from this PR?) that uses PATH_TO_CORE etc. to use the core test steps and test helpers
  • remove the not-needed test steps and test helpers from here, leaving just the extra test steps that are really needed here
  • minimize any other added code
  • put back the regular .drone.star with the existing pipelines, plus a pipeline for these tests

Then we can think about if we merge that, with the tests and code in tests/parallelDeployAcceptance

And next we sort out how to rename/move/merge that into the existing local API tests tests/acceptance structure.

@saw-jan saw-jan mentioned this pull request Dec 17, 2021
Merged
12 tasks
@saw-jan
Copy link
Member Author

saw-jan commented Dec 22, 2021

Closing this.
Implemented in PR #2897

@saw-jan saw-jan closed this Dec 22, 2021
@saw-jan saw-jan deleted the parallel-deploy-tests-poc branch March 11, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj Awaiting requested review from kobergj kobergj will be requested when the pull request is marked ready for review kobergj is a code owner

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis will be requested when the pull request is marked ready for review phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it will be requested when the pull request is marked ready for review individual-it is a code owner

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saw-jan @phil-davis