Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent purging of enabled spaces #3000

Merged
merged 1 commit into from
Jan 20, 2022
Merged

prevent purging of enabled spaces #3000

merged 1 commit into from
Jan 20, 2022

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jan 20, 2022 •
edited
Loading

Description

When a user tries to purge an enabled space we want to return an error.

Motivation and Context

Spaces need to be deleted in 2 steps. First disabling second deleting the space.

How Has This Been Tested?

  • locally using curl

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Code changes

@C0rby C0rby requested review from kobergj and micbar January 20, 2022 15:53
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@C0rby C0rby merged commit ab187e8 into master Jan 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the harden-purge-spaces branch January 20, 2022 17:33
@micbar micbar mentioned this pull request Feb 16, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@micbar micbar Awaiting requested review from micbar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C0rby @kobergj