Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Fix sharing tests in parallel deployment tests #3090

Merged
merged 1 commit into from
Feb 3, 2022
Merged

[tests-only] Fix sharing tests in parallel deployment tests #3090

merged 1 commit into from
Feb 3, 2022

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Feb 2, 2022 •
edited
Loading

Description

This PR fixes the sharing tests that were not working in parallel deployment pipelines

Related Issue

How Has This Been Tested?

  • test environment: local & CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan added the QA:team label Feb 2, 2022
@saw-jan saw-jan self-assigned this Feb 2, 2022
@saw-jan saw-jan changed the title fix sharing tests in parallel deployment [tests-only] Fix sharing tests in parallel deployment tests Feb 2, 2022
@owncloud owncloud deleted a comment from update-docs bot Feb 2, 2022
phil-davis
phil-davis approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @saw-jan if you are finished with this, please take out of draft and merge.

@saw-jan saw-jan marked this pull request as ready for review February 3, 2022 03:20
@ownclouders
Copy link
Contributor

ownclouders commented Feb 3, 2022 •
edited
Loading

💥 Acceptance test accountsUITests failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 9b66eb0 into master Feb 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-sharing-tests branch February 3, 2022 04:36
ownclouders pushed a commit that referenced this pull request Feb 3, 2022
@saw-jan
commit 9b66eb0
a3b1f58 
Merge: 9923f1f 83a5d2d
Author: Saw-jan Gurung <saw.jan.grg3e@gmail.com>
Date:   Thu Feb 3 10:21:04 2022 +0545

    Merge pull request #3090 from owncloud/fix-sharing-tests

    [tests-only] Fix sharing tests in parallel deployment tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar micbar is a code owner

@wkloucek wkloucek Awaiting requested review from wkloucek wkloucek is a code owner

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sharing test should work in parallel deployment but is failing
3 participants
@saw-jan @ownclouders @phil-davis