[tests-only] [full-ci] Fix expected-failures references #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
force-pushed
the
fix-expected-failures-references
branch
from
17b563d
to
c0858fd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
phil-davis
commented
Feb 2, 2022
| @@ -337,21 +337,6 @@ Other free text and markdown formatting can be used elsewhere in the document if | |||
| ### [share permissions not enforced](https://github.com/owncloud/product/issues/270) | |||
| - [webUIResharing1/reshareUsers.feature:248](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIResharing1/reshareUsers.feature#L248) | |||
|
|
|||
| #### [Searching sharee with displayname](https://github.com/owncloud/ocis/issues/547) | |||
There was a problem hiding this comment.
This is an expected-failures file for web test scenarios. Somehow these apiSharees entries were added here. They don't belong here. They didn't cause a problem because there is no webUI test pipeline that runs a suite called apiSharees, so these lines never got processed by any pipeline.
9 tasks
kiranparajuli589
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix errors in the feature file links in expected-failures files. A few have got out-of-date line numbers, wrong feature file names etc.
I have a PHP script that I used to parse locally and find these. I will think about where to put that so that we can automatically find these accidental errors. They don't cause an actual problem for CI, it is just confusing for real people if they look at or click a link that is wrong.
How Has This Been Tested?
Types of changes
Checklist: