Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add consul as registry option #3133

Merged
merged 1 commit into from
Feb 9, 2022
Merged

add consul as registry option #3133

merged 1 commit into from
Feb 9, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Feb 8, 2022

Description

adds consul as registry option (helpful for HashiCorp environments like Nomad)

Related Issue

Motivation and Context

How Has This Been Tested?

Run a consul:

  consul:
    image: consul:latest
    command: consul agent -dev -client 0.0.0.0
    ports:
      - "8500:8500"
      - "8600:8600/udp"

use the consul registry in oCIS:

      MICRO_REGISTRY: consul
      MICRO_REGISTRY_ADDRESS: consul:8500

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Feb 8, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek mentioned this pull request Feb 8, 2022
Closed
9 tasks
@wkloucek wkloucek force-pushed the add-consol-as-registry-option branch from f810456 to 3215cb7 Compare February 8, 2022 15:58
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit f152e4f into master Feb 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-consol-as-registry-option branch February 9, 2022 09:49
ownclouders pushed a commit that referenced this pull request Feb 9, 2022
@wkloucek
commit f152e4f
5c9b3f8 
Merge: 64b1450 3215cb7
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Wed Feb 9 10:49:28 2022 +0100

    Merge pull request #3133 from owncloud/add-consol-as-registry-option

    add consul as registry option
@micbar micbar mentioned this pull request Feb 16, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@butonic butonic Awaiting requested review from butonic

@kobergj kobergj Awaiting requested review from kobergj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @C0rby