Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove need for external ocis-net network #3238

Conversation

rpocklin
Copy link
Contributor

Description

Tidy up the deployments/examples/ocis_individual_services example so that the instructions work.

Motivation and Context

No need for manually creating a network via docker create network ocis-net (not in example instructions).

How Has This Been Tested?

Tested in Windows 10 / WSL 2 Ubuntu and works as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes

@update-docs
Copy link

update-docs bot commented Feb 25, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek force-pushed the ocis-individual-services-fix-external-network branch from 9ca07a4 to 0d362ae Compare March 14, 2022 08:07
@wkloucek wkloucek merged commit 2d44e9e into owncloud:master Mar 14, 2022
ownclouders pushed a commit that referenced this pull request Mar 14, 2022
Merge: 5f5e935 0d362ae
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon Mar 14 09:11:46 2022 +0100

    Merge pull request #3238 from rpocklin/ocis-individual-services-fix-external-network

    fix: remove need for external ocis-net network
@micbar micbar mentioned this pull request Mar 29, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants