Change thumbnails API and implement gif thumbnails #3272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By popular demand, I have implement animated thumbnails for gifs.
This PR is not ready yet. I want to refactor the thumbnail code a little bit more and also the download of the thumbnails from the thumbnails service shouldn't be done via grpc. I have run into the problem that the gif thumbnails were bigger than the allowed grpc message size. So to prevent this I would implement a similar solution like the downloads in reva were there is a http endpoint for the actual download.API changes are implemented.
Here is a preview of the animated thumbnails:
2022-03-04.19-10-06.mp4
In addition the thumbnails API was changed a bit because GRPC only allows certain message sizes and while testing some gif thumbnails I already ran into the maximum. These changes allow bigger thumbnails. (file size not resolution, but it most often correlates so...)