Bring audit to monorepo #3288
Bring audit to monorepo #3288
Conversation
Signed-off-by: jkoberg <jkoberg@owncloud.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
|
Kudos, SonarCloud Quality Gate passed! |
| Usage: "Check health status", | ||
| Action: func(c *cli.Context) error { | ||
| // Not implemented | ||
| return nil |
There was a problem hiding this comment.
Can we 1) either give a basic health status back or 2) create a ticket to implement it in a separate task
| Usage: "print the version of this binary and the running extension instances", | ||
| Category: "info", | ||
| Action: func(c *cli.Context) error { | ||
| // not implemented |
|
|
||
| // Auditlog holds audit log information | ||
| type Auditlog struct { | ||
| LogToConsole bool `ocisConfig:"log_to_console" env:"AUDIT_LOG_TO_CONSOLE" desc:"logs to Stdout if true"` |
There was a problem hiding this comment.
Are these two Options exclusive or can both be set to true?
There was a problem hiding this comment.
both can be set to true
| LogToConsole bool `ocisConfig:"log_to_console" env:"AUDIT_LOG_TO_CONSOLE" desc:"logs to Stdout if true"` | ||
| LogToFile bool `ocisConfig:"log_to_file" env:"AUDIT_LOG_TO_FILE" desc:"logs to file if true"` | ||
| FilePath string `ocisConfig:"filepath" env:"AUDIT_FILEPATH" desc:"filepath to the logfile. Mandatory if LogToFile is true"` | ||
| Format string `ocisConfig:"format" env:"AUDIT_FORMAT" desc:"log format. using json is advised"` |
There was a problem hiding this comment.
Which other options besides json are possible?
There was a problem hiding this comment.
At the moment none. But I figured it be beneficial to have it configurable. I can remove and hardcode it if you say thats too confusing.
Signed-off-by: jkoberg jkoberg@owncloud.com
Description
Audit service may now live in shiny mono repo
Motivation and Context
Less maintenance when in monorepo
How Has This Been Tested?
Types of changes
Checklist: