Fix error handling in GetUsers #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
approved these changes
Mar 22, 2022
rhafer
force-pushed
the
graph-getuser-err
branch
from
148e28c
to
aab2d17
Compare
Good point. Added. |
kulmann
reviewed
Mar 22, 2022
A missing return statement caused GetUsers to return misleading results when the identity backend returned an error.
rhafer
force-pushed
the
graph-getuser-err
branch
from
aab2d17
to
3c16713
Compare
|
💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled... |
|
Kudos, SonarCloud Quality Gate passed! |
C0rby
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A missing return statement caused GetUsers to return missleading results
when the identity backend returned an error.