Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Fix shares graph #3365

Merged
merged 9 commits into from
Mar 29, 2022
Merged

[full-ci] Fix shares graph #3365

merged 9 commits into from
Mar 29, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Mar 22, 2022

Description

Change: Add remote item to mountpoint and fix spaceID

A mountpoint represents the mounted share on the share receivers side. The original resource is located where the grant has been set. This item is now shown as libregraph remoteItem on the mountpoint. While adding this, we fixed the spaceID for mountpoints.

{
            "driveAlias": "mountpoint/test",
            "driveType": "mountpoint",
            "id": "a0ca6a90-a365-4782-871e-d44447bbc668!28430982-37ee-4492-9cef-dc94a7807211",
            "name": "Test",
            "owner": {
                "user": {
                    "id": "ddc2004c-0977-11eb-9d3f-a793888cd0f8"
                }
            },
            "quota": {
                "remaining": 0,
                "state": "normal",
                "total": 0,
                "used": 0
            },
            "root": {
                "eTag": "\"3cacbbbd2838ff0996d4723f049a2c9e\"",
                "id": "a0ca6a90-a365-4782-871e-d44447bbc668!28430982-37ee-4492-9cef-dc94a7807211",
                "remoteItem": {
                    "eTag": "\"3cacbbbd2838ff0996d4723f049a2c9e\"",
                    "folder": {},
                    "id": "ddc2004c-0977-11eb-9d3f-a793888cd0f8!fb5963b0-7dfc-48cc-ac69-daed96fcfa41",
                    "lastModifiedDateTime": "2022-03-25T11:33:22.051056+01:00",
                    "name": "Test",
                    "size": 629,
                    "webDavUrl": "https://localhost:9200/dav/spaces/ddc2004c-0977-11eb-9d3f-a793888cd0f8!fb5963b0-7dfc-48cc-ac69-daed96fcfa41"
                },
                "webDavUrl": "https://localhost:9200/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668!28430982-37ee-4492-9cef-dc94a7807211"
            }
        },

Related Issue

Motivation and Context

  • Needed for using the share jail

How Has This Been Tested?

  • manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar force-pushed the fix-shares-graph branch 2 times, most recently from 0086322 to 35c7104 Compare March 22, 2022 16:23
@micbar micbar changed the title Fix shares graph [full-ci] Fix shares graph Mar 25, 2022
@micbar micbar force-pushed the fix-shares-graph branch 5 times, most recently from ca623ec to 5c5be6c Compare March 25, 2022 15:13
@micbar micbar marked this pull request as ready for review March 25, 2022 15:14
@micbar micbar force-pushed the fix-shares-graph branch 2 times, most recently from a2f618b to 212dd20 Compare March 26, 2022 20:19
graph/pkg/service/v0/driveitems.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Comments not critical.

go.mod Outdated Show resolved Hide resolved
graph/pkg/service/v0/graph_test.go Outdated Show resolved Hide resolved
@micbar micbar force-pushed the fix-shares-graph branch 3 times, most recently from e27d32a to 62d5c9a Compare March 28, 2022 17:17
@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

79.3% 79.3% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit c523ae8 into master Mar 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-shares-graph branch March 29, 2022 07:13
ownclouders pushed a commit that referenced this pull request Mar 29, 2022
Merge: 4a0592d f3e02e0
Author: Michael Barz <mbarz@owncloud.com>
Date:   Tue Mar 29 09:13:26 2022 +0200

    Merge pull request #3365 from owncloud/fix-shares-graph

    [full-ci] Fix shares graph
@micbar micbar mentioned this pull request Mar 29, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants