-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Fix shares graph #3365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
force-pushed
the
fix-shares-graph
branch
2 times, most recently
from
March 22, 2022 16:23
0086322
to
35c7104
Compare
micbar
force-pushed
the
fix-shares-graph
branch
5 times, most recently
from
March 25, 2022 15:13
ca623ec
to
5c5be6c
Compare
micbar
force-pushed
the
fix-shares-graph
branch
from
March 25, 2022 15:25
5c5be6c
to
614aaf8
Compare
butonic
reviewed
Mar 25, 2022
butonic
reviewed
Mar 25, 2022
butonic
approved these changes
Mar 25, 2022
micbar
force-pushed
the
fix-shares-graph
branch
2 times, most recently
from
March 26, 2022 20:19
a2f618b
to
212dd20
Compare
kobergj
requested changes
Mar 28, 2022
micbar
force-pushed
the
fix-shares-graph
branch
from
March 28, 2022 09:24
4dfd906
to
0119a1d
Compare
micbar
force-pushed
the
fix-shares-graph
branch
from
March 28, 2022 13:22
691c589
to
3b81027
Compare
kobergj
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Comments not critical.
micbar
force-pushed
the
fix-shares-graph
branch
from
March 28, 2022 13:33
3b81027
to
7c72778
Compare
micbar
force-pushed
the
fix-shares-graph
branch
from
March 28, 2022 14:05
7c72778
to
0d63426
Compare
micbar
force-pushed
the
fix-shares-graph
branch
from
March 28, 2022 15:19
d1ca349
to
1a3bd17
Compare
micbar
force-pushed
the
fix-shares-graph
branch
3 times, most recently
from
March 28, 2022 17:17
e27d32a
to
62d5c9a
Compare
micbar
force-pushed
the
fix-shares-graph
branch
from
March 28, 2022 18:06
62d5c9a
to
d04d93b
Compare
micbar
force-pushed
the
fix-shares-graph
branch
from
March 28, 2022 19:50
2411be2
to
ab00331
Compare
micbar
force-pushed
the
fix-shares-graph
branch
from
March 28, 2022 20:27
c6335c8
to
9788b53
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change: Add remote item to mountpoint and fix spaceID
A mountpoint represents the mounted share on the share receivers side. The original resource is located where the grant has been set. This item is now shown as libregraph remoteItem on the mountpoint. While adding this, we fixed the spaceID for mountpoints.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: