drop json config support #3366
Merged
drop json config support #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
wkloucek
force-pushed
the
drop-json-config-support
branch
from
9201437
to
a31f8c0
Compare
wkloucek
force-pushed
the
drop-json-config-support
branch
from
a31f8c0
to
3d4293c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
wkloucek
requested review from
micbar,
phil-davis,
individual-it,
kulmann and
pascalwengerter
as code owners
wkloucek
requested review from
dragonchaser,
C0rby and
kobergj
and removed request for
phil-davis,
individual-it,
kulmann and
pascalwengerter
wkloucek
added a commit
to owncloud/ocis-charts
that referenced
this pull request
Mar 28, 2022
ownclouders
pushed a commit
that referenced
this pull request
Mar 28, 2022
wkloucek
added a commit
to owncloud/web
that referenced
this pull request
Mar 28, 2022
10 tasks
fschade
pushed a commit
to owncloud/web
that referenced
this pull request
Mar 28, 2022
wkloucek
added a commit
to owncloud/ocis-hello
that referenced
this pull request
Mar 28, 2022
|
The documentation in some cases only give examples of json files, for example I have no clue about how to enable a plugin using yaml configuration. Could somebody with the knowledge possibly update the documentation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR drops json config support for all oCIS services. From now on only YAML config files are supported.
Related Issue
Motivation and Context
YAML is a superset of JSON and allows one to add comments. This enables us to add comments to example config files and the user to document his/her settings.
We also don't want to generate example config files for both JSON and YAML.
How Has This Been Tested?
Types of changes
Checklist: