Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement user and group audit events #3467

Merged
merged 1 commit into from
Apr 11, 2022
Merged

implement user and group audit events #3467

merged 1 commit into from
Apr 11, 2022

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Apr 5, 2022

Added audit events for users and groups. This will log:

  • User creation
  • User deletion
  • User property change (currently only email)
  • Group creation
  • Group deletion
  • Group member add
  • Group member remove

Requires: cs3org/reva#2717

@C0rby C0rby requested review from rhafer and kobergj April 5, 2022 16:36
@C0rby C0rby self-assigned this Apr 5, 2022
@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled...

@C0rby C0rby marked this pull request as ready for review April 6, 2022 12:54
@C0rby C0rby force-pushed the user-group-audit branch 3 times, most recently from 371d942 to 922e061 Compare April 7, 2022 08:31
rhafer
rhafer previously requested changes Apr 7, 2022
View reviewed changes
graph/pkg/service/v0/users.go Outdated Show resolved Hide resolved
@C0rby C0rby requested a review from rhafer April 8, 2022 13:57
kobergj
kobergj requested changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a copy&paste mistake 😛

audit/pkg/types/conversion.go Outdated Show resolved Hide resolved
graph/pkg/service/v0/groups.go Outdated Show resolved Hide resolved
@C0rby C0rby force-pushed the user-group-audit branch 2 times, most recently from 8648236 to 28428d5 Compare April 11, 2022 07:57
@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

4.4% 4.4% Coverage
0.3% 0.3% Duplication

kobergj
kobergj approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@C0rby C0rby requested a review from kobergj April 11, 2022 08:53
@kobergj kobergj dismissed rhafer’s stale review April 11, 2022 09:07

requested changes executed

@C0rby C0rby merged commit ecddaef into master Apr 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the user-group-audit branch April 11, 2022 09:23
ownclouders pushed a commit that referenced this pull request Apr 11, 2022
commit ecddaef
f3cb7a2 
Merge: 0ef1826 81e731f
Author: David Christofas <dchristofas@owncloud.com>
Date:   Mon Apr 11 11:23:37 2022 +0200

    Merge pull request #3467 from owncloud/user-group-audit

    implement user and group audit events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar Awaiting requested review from micbar

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

@rhafer rhafer Awaiting requested review from rhafer

@kobergj kobergj Awaiting requested review from kobergj

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@C0rby @ownclouders @rhafer @kobergj