Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jarnaiz/behat-junit-formatter from acceptance tests #3553

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Remove jarnaiz/behat-junit-formatter from acceptance tests #3553

merged 3 commits into from
Apr 21, 2022

Conversation

kiranparajuli589
Copy link
Contributor

Description

  • composer allow plugins
  • remove jarniaz/behat-junit-formatter

Related Issue

@kiranparajuli589
Remove jarnaiz/behat-junit-formatter from acceptance tests
b802c78 
Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
@update-docs
Copy link

update-docs bot commented Apr 21, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kiranparajuli589 kiranparajuli589 mentioned this pull request Apr 21, 2022
Closed
4 tasks
@kiranparajuli589 kiranparajuli589 self-assigned this Apr 21, 2022
phil-davis
phil-davis reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we don't want to commit all the source code of composer-bin-plugin

@kiranparajuli589
Removed vendor php
c82a3f4 
Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
@kiranparajuli589 kiranparajuli589 force-pushed the remove-jarnaiz/behat-junit-formatter branch from 5818cd7 to c82a3f4 Compare April 21, 2022 09:57
@kiranparajuli589
Copy link
Contributor Author

IMO we don't want to commit all the source code of composer-bin-plugin

removed all vendor-php stuffs

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/10794/38/15
@kiranparajuli589
something in parallel deployment test pipelines still mentions jarnaiz/behat-junit-formatter0

@kiranparajuli589
Removed formatter config from parallel deployment config
4c16b16 
Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
@kiranparajuli589
Copy link
Contributor Author

kiranparajuli589 commented Apr 21, 2022 •
edited
Loading

https://drone.owncloud.com/owncloud/ocis/10794/38/15 @kiranparajuli589 something in parallel deployment test pipelines still mentions jarnaiz/behat-junit-formatter0

oh yes, there is a separate config for parallel deployment tests. Removed the formatter-related config from there too.

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit ed4a809 into master Apr 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove-jarnaiz/behat-junit-formatter branch April 21, 2022 11:06
ownclouders pushed a commit that referenced this pull request Apr 21, 2022
@phil-davis
commit ed4a809
1d5a4a3 
Merge: addbbda 4c16b16
Author: Phil Davis <phil@jankaritech.com>
Date:   Thu Apr 21 16:51:05 2022 +0545

    Merge pull request #3553 from owncloud/remove-jarnaiz/behat-junit-formatter

    Remove jarnaiz/behat-junit-formatter from acceptance tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiranparajuli589 @phil-davis