Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Bump WEB_COMMITID #3584

Closed
wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

Description

Note: WIP - this may or may not be possible to do at the moment.
It depends what real changes have happened to the web app and web tests since web was last pulled-in to oCIS.

Related Issue

owncloud/QA#738

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Apr 26, 2022
@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/ocis/10921/44/9

runsh: Total unexpected failed scenarios throughout the test run:
webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:136
  Scenario: sharing indicator for group shares stays up to date # features/webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:136
- Connecting to selenium on port 4444...

ℹ Connected to selenium on port 4444 (228ms).
  Using: chrome (94.0.4606.61) on Linux platform.

    Given the setting "shareapi_auto_accept_share" of app "core" has been set to "no" in the server
    And the administrator has set the default folder for received shares to "Shares" in the server
    And these users have been created with default attributes and without skeleton files in the server:
      │ username │
      │ Alice    │
      │ Brian    │
      │ Carol    │
    And group "grp1" has been created in the server
    And user "Alice" has been added to group "grp1" in the server
    And user "Brian" has been added to group "grp1" in the server
    Given these groups have been created in the server:
      │ groupname │
      │ grp2      │
      │ grp3      │
      │ grp4      │
    And user "Alice" has created folder "simple-folder" in the server
    And user "Alice" has created folder "simple-folder2" in the server
    And user "Alice" has created file "simple-folder/testimage.png" in the server
    When user "Alice" has logged in using the webUI
√ Element <input[autocomplete="kopano-account username"]> was visible after 641 milliseconds.
√ Element <input[autocomplete="kopano-account username"]> was not present after 81 milliseconds.
√ Element <#files-view> was visible after 593 milliseconds.
    Then the following resources should not have share indicators on the webUI
      │ simple-folder │
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='simple-folder' or @data-test-resource-path='/simple-folder')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 22 milliseconds.
waiting for 500ms ...
Timed out while waiting for element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='simple-folder' or @data-test-resource-path='/simple-folder')]/ancestor::tr[contains(@class, "oc-tbody-tr")]//*[contains(@class, "oc-status-indicators-indicator")]> to be present for 300 milliseconds. - expected "visible" but got: "not found" (310ms)
undefined    When the user shares folder "simple-folder" with group "grp2" as "Viewer" using the webUI
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='simple-folder' or @data-test-resource-path='/simple-folder')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 16 milliseconds.
waiting for 500ms ...
Timeout waiting for Ajax calls to start
waiting for 500ms ...
√ Element <//*[@id="sidebar-panel-sharing-item"]//*[contains(@class, "sidebar-panel__body-content")]> was present after 8 milliseconds.
√ Element <#files-share-invite-input> was visible after 23 milliseconds.
√ Element <#new-collaborators-form .vs__dropdown-menu .files-collaborators-autocomplete-user-text> was visible after 24 milliseconds.
√ Element <#files-collaborators-role-button-new> was visible after 24 milliseconds.
√ Element <#new-collaborators-form-create-button> was present after 11 milliseconds.
    And the user shares folder "simple-folder" with group "grp3" as "Viewer" using the webUI
√ Element <//*[@id="sidebar-panel-sharing-item"]//*[contains(@class, "sidebar-panel__body-content")]> was present after 7 milliseconds.
√ Element <#files-share-invite-input> was visible after 15 milliseconds.
√ Element <#new-collaborators-form .vs__dropdown-menu .files-collaborators-autocomplete-user-text> was visible after 23 milliseconds.
√ Element <#files-collaborators-role-button-new> was visible after 15 milliseconds.
√ Element <#new-collaborators-form-create-button> was present after 8 milliseconds.
    Then the following resources should have share indicators on the webUI
      │ fileName      │ expectedIndicators │
      │ simple-folder │ user-direct        │
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='simple-folder' or @data-test-resource-path='/simple-folder')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 17 milliseconds.
waiting for 500ms ...
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='simple-folder' or @data-test-resource-path='/simple-folder')]/ancestor::tr[contains(@class, "oc-tbody-tr")]//*[contains(@class, "oc-status-indicators-indicator")]> was visible after 23 milliseconds.
    When the user opens folder "simple-folder" using the webUI
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='simple-folder' or @data-test-resource-path='/simple-folder')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 13 milliseconds.
√ Element <//*[self::table[contains(@class, "files-table")] or self::div[contains(@class, "files-empty")] or self::div[contains(@class, "files-not-found")]]> was visible after 31 milliseconds.
    Then the following resources should have share indicators on the webUI
      │ fileName      │ expectedIndicators │
      │ testimage.png │ user-indirect      │
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='testimage.png' or @data-test-resource-path='/testimage.png')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 23 milliseconds.
waiting for 500ms ...
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='testimage.png' or @data-test-resource-path='/testimage.png')]/ancestor::tr[contains(@class, "oc-tbody-tr")]//*[contains(@class, "oc-status-indicators-indicator")]> was visible after 25 milliseconds.
    When the user shares file "testimage.png" with group "grp4" as "Viewer" using the webUI
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='testimage.png' or @data-test-resource-path='/testimage.png')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 14 milliseconds.
waiting for 500ms ...
Timeout waiting for Ajax calls to start
waiting for 500ms ...
√ Element <//*[@id="sidebar-panel-sharing-item"]//*[contains(@class, "sidebar-panel__body-content")]> was present after 8 milliseconds.
√ Element <#files-share-invite-input> was visible after 18 milliseconds.
√ Element <#new-collaborators-form .vs__dropdown-menu .files-collaborators-autocomplete-user-text> was visible after 19 milliseconds.
√ Element <#files-collaborators-role-button-new> was visible after 19 milliseconds.
√ Element <#new-collaborators-form-create-button> was present after 10 milliseconds.
    Then the following resources should have share indicators on the webUI
      │ fileName      │ expectedIndicators │
      │ testimage.png │ user-direct        │
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='testimage.png' or @data-test-resource-path='/testimage.png')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 17 milliseconds.
waiting for 500ms ...
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='testimage.png' or @data-test-resource-path='/testimage.png')]/ancestor::tr[contains(@class, "oc-tbody-tr")]//*[contains(@class, "oc-status-indicators-indicator")]> was visible after 14 milliseconds.
    When the user opens the share dialog for file "testimage.png" using the webUI
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='testimage.png' or @data-test-resource-path='/testimage.png')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was visible after 14 milliseconds.
waiting for 500ms ...
Timeout waiting for Ajax calls to start
waiting for 500ms ...
√ Element <//*[@id="sidebar-panel-sharing-item"]//*[contains(@class, "sidebar-panel__body-content")]> was present after 8 milliseconds.
    And the user deletes "grp4" as collaborator for the current file using the webUI
√ Element <//span[contains(@class, "files-collaborators-collaborator-name") and contains(text(),"grp4")]/ancestor::div[contains(@class, "files-collaborators-collaborator")]//button[contains(@class, "collaborator-edit-dropdown-options-btn")]> was visible after 27 milliseconds.
√ Element <//button[contains(@class, "remove-share")]> was visible after 24 milliseconds.
waiting for 500ms ...
Timed out while waiting for element <//div[contains(@class, "oc-modal")]> to be present for 10000 milliseconds. - expected "visible" but got: "not found" (10019ms)
undefined    ✖ failed
      Timed out while waiting for element <//div[contains(@class, "oc-modal")]> to be present for 10000 milliseconds. - expected "visible" but got: "not found" (10019ms)
      Timed out while waiting for element <//div[contains(@class, "oc-modal")]> to be present for 10000 milliseconds. - expected "visible" but got: "not found" (10019ms)
          at Proxy.deleteShareWithUserGroup (/srv/app/web/tests/acceptance/pageObjects/FilesPageElement/SharingDialog/collaboratorsDialog.js:21:10)
          at World.<anonymous> (/srv/app/web/tests/acceptance/stepDefinitions/sharingContext.js:605:77)
          

Something might have changed with the share dialog and the latest test code in web will not work against the web app currently bundled in oCIS.

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/ocis/10921/44/9

runsh: Total unexpected failed scenarios throughout the test run:
webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:17
Timed out while waiting for element <//div[contains(@class, "oc-modal")]> to be present for 10000 milliseconds. - expected "visible" but got: "not found" (10015ms)
undefined    ✖ failed

Similar fail happened for users as for groups.

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pascalwengerter
Copy link
Contributor

Why try to bump the web commit id without a corresponding release (which is schedule for next week)? We already test compatibility with oCIS by bumping its commit id in web

@phil-davis
Copy link
Contributor Author

Why try to bump the web commit id without a corresponding release (which is schedule for next week)? We already test compatibility with oCIS by bumping its commit id in web

If it was easy and "just worked" then we would get to use whatever improved web test code had happened recently. Since it is not completely easy, I will let it be bumped along with the next release of web into oCIS.

@phil-davis phil-davis closed this Apr 27, 2022
@phil-davis phil-davis deleted the web-commit-id-20220426 branch April 27, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants