-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align service naming #3606
Align service naming #3606
Conversation
39356fa
to
42a1e4c
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
42a1e4c
to
88b892a
Compare
💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-2 failed. Further test are cancelled... |
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should then also rename the respective config in ocis-pkg/config/config.go
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Author: Jörn Friedrich Dreyer <jfd@owncloud.com> Date: Mon May 2 12:44:21 2022 +0200 Align service naming (#3606) * use configured names as service names in ocis runtime Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * add changelog Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * correct service names for group and storage-shares Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * use correct service names in .drone.star Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * align ocis-pkg/config/config.go Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
We now reflect the configured service names when listing them in the ocis runtime.
Follow up PRs:
storage-metadata
-> justmetadata
storageapprovider.go
->approvider.go
with the command namestorage-app-provider
->app-provider
.drone.star
fileOCIS_RUN_EXTENSIONS
partly fixes #3603