Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Bump web to v5.5.0-rc.2 #3664

Merged
merged 3 commits into from
May 4, 2022
Merged

[full-ci] Bump web to v5.5.0-rc.2 #3664

merged 3 commits into from
May 4, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented May 3, 2022

Usually we only bump to final releases of oC Web. To get in sync for the beta and find out about blockers early, we'll update to a web release candidate for now.

@kulmann kulmann changed the title Bump web to v5.5.0-rc.2 [full-ci] Bump web to v5.5.0-rc.2 May 3, 2022
@kulmann
Copy link
Member Author

kulmann commented May 3, 2022

@pascalwengerter afaik the tests failing in https://drone.owncloud.com/owncloud/ocis/11325/48/9 are all flaky, is that correct?

@pascalwengerter
Copy link
Contributor

@pascalwengerter afaik the tests failing in https://drone.owncloud.com/owncloud/ocis/11325/48/9 are all flaky, is that correct?

The line 56/60 for sure, but given that one fails and one passes unexpectedly hints at a missing update of the expected failures 🤔🥸 line 172 needs investigation, could be it'll be dropped by updating expected failures, could be random or legit otherwise

@kulmann
Copy link
Member Author

kulmann commented May 3, 2022

@pascalwengerter afaik the tests failing in https://drone.owncloud.com/owncloud/ocis/11325/48/9 are all flaky, is that correct?

The line 56/60 for sure, but given that one fails and one passes unexpectedly hints at a missing update of the expected failures 🤔🥸 line 172 needs investigation, could be it'll be dropped by updating expected failures, could be random or legit otherwise

Hm, true 🤔 line 172 has an issue linked that is already closed. Maybe there just was no full ci run in the meantime 🤔 Removed it from expected failures.

@pascalwengerter
Copy link
Contributor

@pascalwengerter afaik the tests failing in https://drone.owncloud.com/owncloud/ocis/11325/48/9 are all flaky, is that correct?

The line 56/60 for sure, but given that one fails and one passes unexpectedly hints at a missing update of the expected failures 🤔🥸 line 172 needs investigation, could be it'll be dropped by updating expected failures, could be random or legit otherwise

Pushed a commit that sorted the 56/60 line thing, now let's hope the flakiness isn't too bad

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, squash-able 🤓

@kulmann kulmann merged commit 16c3b1a into master May 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the bump-web-5.5.0-rc.2 branch May 4, 2022 08:27
ownclouders pushed a commit that referenced this pull request May 4, 2022
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Wed May 4 10:27:07 2022 +0200

    [full-ci] Bump web to v5.5.0-rc.2 (#3664)

    Bump web to v5.5.0-rc.2

    Co-authored-by: Pascal Wengerter <pascal@wengerter.info>
ownclouders pushed a commit that referenced this pull request May 4, 2022
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Wed May 4 10:27:07 2022 +0200

    [full-ci] Bump web to v5.5.0-rc.2 (#3664)

    Bump web to v5.5.0-rc.2

    Co-authored-by: Pascal Wengerter <pascal@wengerter.info>
@micbar micbar mentioned this pull request May 10, 2022
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants