Bugfix: Fix multiple configuration environment variables for the storage-users extension #3802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've fixed multiple environment variable configuration options for the storage-users extension:
STORAGE_USERS_GRPC_ADDR
was used to configure both the address of the http and grpc server.This resulted in a failing startup of the storage-users extension if this config option is set,
because the service tries to double-bind the configured port (one time for each of the http and grpc server). You can now configure the grpc server's address with the environment variable
STORAGE_USERS_GRPC_ADDR
and the http server's address with the environment variableSTORAGE_USERS_HTTP_ADDR
STORAGE_USERS_S3NG_USERS_PROVIDER_ENDPOINT
was used to configure the permissions service endpoint for the S3NG driver and was therefore renamed toSTORAGE_USERS_S3NG_PERMISSIONS_ENDPOINT
STORAGE_USERS_PERMISSION_ENDPOINT
, which was previously only used by the S3NG driver.WARNING: this could be considered a breaking change
Related Issue
Motivation and Context
fix the config
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: