Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce service registry cache #3833

Merged
merged 1 commit into from
May 19, 2022
Merged

introduce service registry cache #3833

merged 1 commit into from
May 19, 2022

Conversation

wkloucek
Copy link
Contributor

Description

Enhancement: Introduce service registry cache

We've improved the service registry / service discovery by
setting up registry caching (TTL 20s), so that not every requests
has to do a lookup on the registry.

Related Issue

  • none

Motivation and Context

  • don't put too much pressure on the service registry
  • speed up requests (since a registry lookup takes time)

How Has This Been Tested?

  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@butonic butonic merged commit 49cac99 into owncloud:master May 19, 2022
ownclouders pushed a commit that referenced this pull request May 19, 2022
@butonic
commit 49cac99
d4e677e 
Merge: 47b6904 b596d1d
Author: Jörn Friedrich Dreyer <jfd@owncloud.com>
Date:   Thu May 19 12:25:13 2022 +0000

    Merge pull request #3833 from wkloucek/registry-cache

    introduce service registry cache
@wkloucek wkloucek deleted the registry-cache branch May 20, 2022 07:15
@micbar micbar mentioned this pull request May 25, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@micbar micbar Awaiting requested review from micbar

@rhafer rhafer Awaiting requested review from rhafer

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @butonic