Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase access token duration to 1 day #3850

Merged
merged 1 commit into from
May 23, 2022
Merged

Increase access token duration to 1 day #3850

merged 1 commit into from
May 23, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented May 23, 2022

Description

We currently have an issue in web which causes a hard page load / redirect to the personal space view after token expiry / during token refresh. Fixing the issue in web is quite some work as it involves a lot of loose ends (see linked ticket). In order to mitigate this annoying behaviour I'd like to increase the access token duration to 1 day.

Do we need a changelog item for this?

Is 10 minutes a conscious decision / reasonable value? Or do we want to have e.g. 30 or 60 minutes when we fixed the issue in web and can revert to a smaller value again here?

Related Issue

Motivation and Context

Mitigate an annoying redirect during token refresh.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented May 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented May 23, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-7 failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann self-assigned this May 23, 2022
micbar
micbar approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workaround approved

@micbar micbar merged commit 3cae4fc into master May 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the increase-access-token-lifetime branch May 23, 2022 17:39
ownclouders pushed a commit that referenced this pull request May 23, 2022
@micbar
commit 3cae4fc
b72dd91 
Merge: ac5738c 49a666b
Author: Michael Barz <mbarz@owncloud.com>
Date:   Mon May 23 19:39:30 2022 +0200

    Merge pull request #3850 from owncloud/increase-access-token-lifetime

    Increase access token duration to 1 day
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

@butonic butonic Awaiting requested review from butonic

@C0rby C0rby Awaiting requested review from C0rby

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kulmann @ownclouders @micbar